Conversation
mmagician
reviewed
Sep 23, 2025
crates/miden-lib/asm/account_components/network_fungible_faucet.masm
Outdated
Show resolved
Hide resolved
mmagician
reviewed
Sep 25, 2025
MINT & BURN notes.MINT & BURN notes.
mmagician
reviewed
Sep 25, 2025
crates/miden-lib/asm/miden/contracts/faucets/network_fungible.masm
Outdated
Show resolved
Hide resolved
bobbinth
reviewed
Sep 26, 2025
Contributor
bobbinth
left a comment
There was a problem hiding this comment.
Thank you! Looks good. Not a full review but I left some comments inline. Some of the, are more like open questions for the future which probably don't need to affect this PR. To summarize some of them:
- Do we want the
MINTand/orBURNnotes to be generic - i.e., work for non-fungible assets as well? - Should we assume that the
BURNnote always carries 1 asset? This is somewhat related to the first question, but also may impact fee handling.
crates/miden-lib/asm/miden/contracts/faucets/network_fungible.masm
Outdated
Show resolved
Hide resolved
crates/miden-lib/asm/miden/contracts/faucets/network_fungible.masm
Outdated
Show resolved
Hide resolved
crates/miden-lib/asm/miden/contracts/faucets/network_fungible.masm
Outdated
Show resolved
Hide resolved
…s/miden-lib/src/account/faucets/mod.rs
mmagician
reviewed
Oct 2, 2025
… in test (#2013) * chore: explicitly try consume both authenticated and unauthenticated note * chore: update test description
- Migrated documentation from mdbook to docusaurus - Updated protocol_library.md with detailed formatting and resolved merge conflicts - Added proper markdown links and structure - Incorporated new procedures from next branch - Added build and deployment workflows for docs
Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com>
Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com>
Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com>
…for ntx faucet doc comment
05fb587 to
231e39a
Compare
Member
Author
|
Addressed all of @PhilippGackstatter's comments. Biggest change is the refactoring of Now it looks like this: pub struct NetworkFungibleFaucet {
faucet: BasicFungibleFaucet,
owner_account_id: AccountId,
} |
bobbinth
approved these changes
Oct 29, 2025
Contributor
bobbinth
left a comment
There was a problem hiding this comment.
Looks great! Thank you! I left just one small comment inline. After it is addressed, we are good to merge. 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a network faucet component and two new notes for interacting with it:
MINTandBURN.Resolves: #1899 & #1891
Network Fungible Faucet (NTX faucet)
The network fungible faucet with note based authentication builds on top of the standard fungible faucet
miden/faucet.masm, however, has a few key differences:OWNER_CONFIG, whereOWNER_CONFIGis defined as[owner_prefix, owner_suffix, 0, 0]. The two emptyFelts in the config word can be used to have different account ids forburn/mintprivileges.distributeandburnprocedures like thebasic_fungible_faucet, the network faucet adds "wrapper" procedures around thedistributeandburnprocedures. These wrapper procedures check if the sender of the active note is the owner of the faucet.This is what these wrapper procedures look like: