Skip to content

fix formatting of pseudo-elements and pseudo-classes in styled-component#7842

Merged
thorn0 merged 1 commit intoprettier:masterfrom
thorn0:css-in-js-special-suffix
Mar 23, 2020
Merged

fix formatting of pseudo-elements and pseudo-classes in styled-component#7842
thorn0 merged 1 commit intoprettier:masterfrom
thorn0:css-in-js-special-suffix

Conversation

@thorn0
Copy link
Copy Markdown
Member

@thorn0 thorn0 commented Mar 23, 2020 •
edited
Loading

fixes #7826

The solution is pretty dirty, but hopefully it will do for now.

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@thorn0
Copy link
Copy Markdown
Member Author

thorn0 commented Mar 23, 2020

@fisker This is the first PR without Azure Pipelines checks. Could you please check that everything works as expected here?

@thorn0 thorn0 force-pushed the css-in-js-special-suffix branch from c22e3cc to 4de3aa3 Compare March 23, 2020 12:05
@fisker
Copy link
Copy Markdown
Member

fisker commented Mar 23, 2020

#6794 can also fix it, and many styled-component issues.

@thorn0
Copy link
Copy Markdown
Member Author

thorn0 commented Mar 23, 2020

#7826 is a regression that I'd like to fix quickly and release 2.0.2.

@fisker
Copy link
Copy Markdown
Member

fisker commented Mar 23, 2020

Sure, I'll let you know if something missing.

@fisker
Copy link
Copy Markdown
Member

fisker commented Mar 23, 2020

This is taking forever.... Still Queued, this is why I prefer keep both for a while.

@thorn0
Copy link
Copy Markdown
Member Author

thorn0 commented Mar 23, 2020

We might have exceeded some limitations. After I merged #7431, existing PRs went crazy like this:

image

@fisker
Copy link
Copy Markdown
Member

fisker commented Mar 23, 2020

This is because github actions don't clear previous build status on force push.

@thorn0
Copy link
Copy Markdown
Member Author

thorn0 commented Mar 23, 2020

Is this fixable?

@thorn0
Copy link
Copy Markdown
Member Author

thorn0 commented Mar 23, 2020

The CI fail is related to coverage (The coverage upload was rejected because the workflow run is either not in-progress or finished a while ago.). All the tests pass.

alexander-akait
alexander-akait approved these changes Mar 23, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for fast fix, let's do more fixes in #6794

@thorn0 thorn0 merged commit 8ec7bc2 into prettier:master Mar 23, 2020
@thorn0 thorn0 deleted the css-in-js-special-suffix branch March 23, 2020 21:26
@marclemagne marclemagne mentioned this pull request Mar 25, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Formatting incorrect using styled-component component selector pattern

4 participants

@thorn0 @fisker @alexander-akait @sosukesuzuki