Refactor css placeholder for TemplateLiteral #6794
Refactor css placeholder for TemplateLiteral #6794fisker wants to merge 72 commits intoprettier:mainfrom
Conversation
|
I will continue development |
|
@fisker man what are you doing? I want to continue development based on your code, why you remove branch /cc @prettier/core guys it is a violation code of conduct |
|
I restored this branch. You can reopen this. Maybe you can continue work on it. I saw too many multi-parser issues that this PR can resolve, and we can't even use pure |
|
Let's reopen, I think we can fix it in near future |
|
@evilebottnawi You can't reopen this old one? If not I can send another PR |
A bit off topic, but what's wrong with using a Less parser for CSS? |
|
@thorn0 because we should throw an error on invalid syntax, Less allow to use many strange things and many things in Less is not compatibility with pure CSS, at least it would be more logical to use SCSS parser, because SCSS superset of CSS like typescript superset of javascript |
|
@thorn0 @evilebottnawi Sounds like #1784? |
|
Yep |
|
Let's solve it after |
|
@fisker let's postpone it for v2.2, what do you think? I will help you with it |
|
I think I made myself clear, I don't want to involve this! |
Why? Something hard that you can't solve? |
|
I'm so not related to this PR but I agree with to postpone. |
fixes: #6790 , with this changes,
src/language-css/printer-postcss.jscan remove all placeholder logic,will clean laterupdate: already didfixes:
docs/directory)CHANGELOG.unreleased.mdfile following the template.✨Try the playground for this PR✨