Skip to content

Refactor css placeholder for TemplateLiteral #6794

Open
fisker wants to merge 72 commits intoprettier:mainfrom
fisker:css-placeholder-refactor
Open

Refactor css placeholder for TemplateLiteral #6794
fisker wants to merge 72 commits intoprettier:mainfrom
fisker:css-placeholder-refactor

Conversation

@fisker
Copy link
Copy Markdown
Member

@fisker fisker commented Nov 4, 2019

@fisker fisker marked this pull request as ready for review November 4, 2019 10:42
@alexander-akait
Copy link
Copy Markdown
Member

I will continue development

@fisker fisker closed this Nov 21, 2019
@fisker fisker deleted the css-placeholder-refactor branch November 21, 2019 16:20
@alexander-akait
Copy link
Copy Markdown
Member

@fisker man what are you doing? I want to continue development based on your code, why you remove branch

/cc @prettier/core guys it is a violation code of conduct

@fisker fisker restored the css-placeholder-refactor branch January 29, 2020 14:33
@fisker
Copy link
Copy Markdown
Member Author

fisker commented Jan 29, 2020

@evilebottnawi

I restored this branch. You can reopen this.

Maybe you can continue work on it.

I saw too many multi-parser issues that this PR can resolve, and we can't even use pure postcss parser (as you said, we should not use postcss-less for css), because old placeholder uses @ .

@alexander-akait
Copy link
Copy Markdown
Member

Let's reopen, I think we can fix it in near future

@fisker
Copy link
Copy Markdown
Member Author

fisker commented Jan 29, 2020

@evilebottnawi You can't reopen this old one? If not I can send another PR

@thorn0
Copy link
Copy Markdown
Member

thorn0 commented Jan 30, 2020

we should not use postcss-less for css

A bit off topic, but what's wrong with using a Less parser for CSS?

@alexander-akait
Copy link
Copy Markdown
Member

alexander-akait commented Jan 30, 2020

@thorn0 because we should throw an error on invalid syntax, Less allow to use many strange things and many things in Less is not compatibility with pure CSS, at least it would be more logical to use SCSS parser, because SCSS superset of CSS like typescript superset of javascript

@lydell
Copy link
Copy Markdown
Member

lydell commented Jan 30, 2020

@thorn0 @evilebottnawi Sounds like #1784?

@alexander-akait
Copy link
Copy Markdown
Member

Yep

@alexander-akait
Copy link
Copy Markdown
Member

Let's solve it after 2.0 released, because here no breaking changes, just fixes and improvements

@alexander-akait
Copy link
Copy Markdown
Member

@fisker let's postpone it for v2.2, what do you think? I will help you with it

@fisker
Copy link
Copy Markdown
Member Author

fisker commented Jul 28, 2020

I think I made myself clear, I don't want to involve this!
You do whatever you want.

@alexander-akait
Copy link
Copy Markdown
Member

I think I made myself clear, I don't want to involve this!

Why? Something hard that you can't solve?

@sosukesuzuki
Copy link
Copy Markdown
Contributor

I'm so not related to this PR but I agree with to postpone.

@sosukesuzuki sosukesuzuki removed this from the 2.1 milestone Jul 29, 2020
@fisker fisker added this to the 2.2 milestone Jul 30, 2020
Base automatically changed from master to main January 23, 2021 17:13
@thorn0 thorn0 removed this from the 2.3 milestone Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposal: refactor css placeholder for TemplateLiteral

5 participants