build(cmake): Use crashpad targets#207
Merged
Swatinem merged 3 commits intogetsentry:masterfrom Apr 2, 2020
madebr:cmake_crashpad
Merged
build(cmake): Use crashpad targets#207Swatinem merged 3 commits intogetsentry:masterfrom madebr:cmake_crashpad
Swatinem merged 3 commits intogetsentry:masterfrom
madebr:cmake_crashpad
Conversation
Swatinem
reviewed
Mar 31, 2020
Contributor
|
hm, mac is not too happy yet :-( |
Contributor
|
Tests are looking good, and I just merged your cmake changes to crashpad. |
Contributor
Author
|
I've rebased the patches and updated the crashpad submodule. |
Swatinem
approved these changes
Apr 1, 2020
Contributor
|
finally… somehow azure is super flacky right now, and basically only works in the morning EU time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr is in tandem with getsentry/crashpad#7
Should make #205 unnecessary
Fixes #204
I've changed the crashpad submodule to my repo to let CI succeed (🤞)
I'll remove it once getsentry/crashpad#7 gets merged.