cmake: use targets (includes/definitions/... + add install#7
Merged
Swatinem merged 1 commit intogetsentry:getsentryfrom Apr 1, 2020
Merged
cmake: use targets (includes/definitions/... + add install#7Swatinem merged 1 commit intogetsentry:getsentryfrom
Swatinem merged 1 commit intogetsentry:getsentryfrom
Conversation
2168d90 to
b110785
Compare
Swatinem
approved these changes
Mar 31, 2020
Swatinem
left a comment
There was a problem hiding this comment.
This is really awesome stuff! Thank you so much ❤️
Swatinem
approved these changes
Mar 31, 2020
madebr
commented
Mar 31, 2020
Comment on lines
+7
to
+9
| [submodule "third_party/lss/lss"] | ||
| path = third_party/lss/lss | ||
| url = https://chromium.googlesource.com/linux-syscall-support |
Author
There was a problem hiding this comment.
I tried this to get it building on Linux but it gets stuck elsewhere on a "windows.h" include.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows sentry-native to use
crashpadby simply linking tocrashpad::client.No adding include directories, no extra defines, no c++ standards.