cmake: Remove Windows-only install targets from Mac#205
cmake: Remove Windows-only install targets from Mac#205jblazquez wants to merge 1 commit intogetsentry:masterfrom jblazquez:master
Conversation
| LIBRARY DESTINATION "${CMAKE_INSTALL_LIBDIR}" | ||
| ARCHIVE DESTINATION "${CMAKE_INSTALL_LIBDIR}" | ||
| ) | ||
| if(WIN32) |
There was a problem hiding this comment.
I think it should be:
| if(WIN32) | |
| if(MSVC) |
There was a problem hiding this comment.
Good catch. I was looking at the version of crashpad's CMakeLists.txt from the 0.2.2 release and that used to say IF(WIN32) there. I will update to say IF(MSVC) here for consistency with master.
EDIT: Actually, the sentry-native master branch points to a crashpad submodule commit that still says IF(WIN32), so this is consistent with that. Should we keep it this way until someone rolls the version of the crashpad submodule forward?
|
Looks like two CI builders failed with timeouts. How does one retry Azure Pipelines builds? |
by having admin priviledges I guess :-D Also, I don’t think this PR is necessary anymore, @madebr made very good progress restructuring the crashpad CMake files. I will review all this today. |
|
Closing this in favor of #207, but thanks a lot for looking into this! |
This change fixes one part of #204. With this change, you can now build with
-DBUILD_SHARED_LIBS=NOon macOS, as long as you also disable the install target using-DSENTRY_ENABLE_INSTALL=NO.