Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- add `traces_sampler` ([#1108](https://github.com/getsentry/sentry-native/pull/1108))If none of the above apply, you can opt out of this check by adding |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1108 +/- ##
==========================================
+ Coverage 82.62% 82.67% +0.04%
==========================================
Files 53 53
Lines 7896 7930 +34
Branches 1234 1240 +6
==========================================
+ Hits 6524 6556 +32
- Misses 1261 1264 +3
+ Partials 111 110 -1 |
supervacuus
left a comment
There was a problem hiding this comment.
Great work up to now, but a few places still need to be fixed/clarified before we can merge this. A few more tests would also make sense, especially when considering changing the order of the sampling mechanisms.
supervacuus
left a comment
There was a problem hiding this comment.
Thanks for the test effort ❤️. There are only minor things left.
|
From what I understand, this part of the documentation is now obsolete: sentry-native/include/sentry.h Lines 1738 to 1741 in 092de88 |
The first sentence is still valid. The second sentence no longer is. |
Fixes #864
sentry_traces_sampler_functiontypedef (like theon_crashandbefore_sendonessamplingContexttransaction_startis done). (docs PR: feat(native): add traces_sampler support sentry-docs#12333)Core changes (without
tx_cxt->tx_ctxrefactor)