Skip to content

feat(native): add traces_sampler support#12333

Merged
JoshuaMoelans merged 7 commits intomasterfrom
feat/native/traces_sampler_docs
Jan 21, 2025
Merged

feat(native): add traces_sampler support#12333
JoshuaMoelans merged 7 commits intomasterfrom
feat/native/traces_sampler_docs

Conversation

@JoshuaMoelans
Copy link
Copy Markdown
Member

@JoshuaMoelans JoshuaMoelans commented Jan 14, 2025

DESCRIBE YOUR PR

Related to native-SDK PR getsentry/sentry-native#1108

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 11:58am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Jan 21, 2025 11:58am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jan 21, 2025 11:58am

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 14, 2025

Bundle Report

Changes will increase total bundle size by 1.21kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.37MB 1.22kB (0.01%) ⬆️
sentry-docs-client-array-push 9.3MB 6 bytes (-0.0%) ⬇️

Copy link
Copy Markdown
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for updating!

Copy link
Copy Markdown
Collaborator

@supervacuus supervacuus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a minor nit.

JoshuaMoelans and others added 2 commits January 21, 2025 12:31
Co-authored-by: Mischan Toosarani-Hausberger <mischan@abovevacant.com>
…m/native.mdx

Co-authored-by: Mischan Toosarani-Hausberger <mischan@abovevacant.com>
@JoshuaMoelans JoshuaMoelans merged commit 8a026f0 into master Jan 21, 2025
@JoshuaMoelans JoshuaMoelans deleted the feat/native/traces_sampler_docs branch January 21, 2025 15:09
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants