I just wanted to propose some changes to Laravel's container, and it seems that for every new PR to Laravel, you immediately receive a message like the following, and PR is closed.
@taylorotwell @driesvints could you explain why?
#PHP #laravel
Kamil Ruczyński 🚀
837 posts
Kamil Ruczyński 🚀
@Sarvendev
Staff Software Engineer | Sharing insights on #TDD, #DDD, #Architecture, #Scalability, and #Performance
Joined November 2009
- Attention Laravel developers! 🚨 Check out my latest article on uncovering the bottlenecks of Laravel's container for optimizing app performance. A must-read for any developer looking to improve their app's performance! (Link in the comment) #laravel #performance
- Just rediscovered this excellent article by @ocramius on when to declare classes final. Though written in 2015, the insights are still relevant today. Highly recommend giving it a read! Do you use final or not? ocramius.github.io/blog/when-to-d…
- “PHP Annotated” Newsletter by @jetbrains is probably the best newsletter about PHP. So, it's really satisfying to see another content created by me in this newsletter for the second time in a row this year.
- Replying to @SarvendevIf you don't want people to propose changes, simply write a red warning explicitly here: laravel.com/docs/11.x/cont… Now, it is really disappointing to see something like this. People spend their time preparing changes, and you just close the PR immediately.
- "Unit testing tips" has over 900 stars on Github. It seems to be a valuable guide for lots of engineers, which highly motivates me to keep going spreading the knowledge about tests and improve this guide and add more tips this year. github.com/sarven/unit-te…
- Maintainability of tests Maintainability refers to the ease with which test code can be understood, modified, and extended over time. A maintainable test suite is well-organized, clear, and concise, ⬇️
- My article about Circuit Breaker is in the PHP Annotated Newsletter. Check this out.PHP Annotated – April 2020 blog.jetbrains.com/phpstorm/2020/… This edition reviews 10 new RFCs from PHP Internals, Composer 2.0 alpha, and other releases, as well as articles on Laravel and Symfony, best practices, useful tools, videos, and podcasts.
- Replying to @jeffreyrossum @taylorotwell and 2 others@jeffreyrossum Because closing almost all PRs with a generic message which looks like an automated one looks weird. Don't you think? It isn't rather a normal process in the Open source world.
