Skip to content

fix: correct Client and Connection type annotations #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tswast merged 1 commit into from
Nov 10, 2021
Merged

fix: correct Client and Connection type annotations #156

tswast merged 1 commit into from
Nov 10, 2021

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Nov 10, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #155 🦕

@tswast tswast requested a review from a team as a code owner November 10, 2021 15:54
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 10, 2021
@tswast tswast mentioned this pull request Nov 10, 2021
Merged
1 task
@tswast tswast merged commit a427681 into main Nov 10, 2021
@tswast tswast deleted the issue155-mypy branch November 10, 2021 16:03
@plamut
Copy link
Contributor

plamut commented Nov 10, 2021

I needed to circumvent this with # type: ignore in BigQuery's v3 branch, good to see it fixed!

gcf-merge-on-green bot pushed a commit that referenced this pull request Nov 10, 2021
@release-please
chore: release 2.2.1 (#157)
a4290ec 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.2.1](https://www.github.com/googleapis/python-cloud-core/compare/v2.2.0...v2.2.1) (2021-11-10)


### Bug Fixes

* correct Client and Connection type annotations ([#156](https://www.github.com/googleapis/python-cloud-core/issues/156)) ([a427681](https://www.github.com/googleapis/python-cloud-core/commit/a427681913ab76379e007a8c3ae519b41e8cee62))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@plamut plamut plamut approved these changes

@busunkim96 busunkim96 busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

mypy failing with latest google-cloud-core

3 participants

@tswast @plamut @busunkim96