Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

feat: add 3.9 support and drop 3.5#167

Merged
busunkim96 merged 15 commits intomasterfrom
add-constraints-file
Dec 4, 2020
Merged

feat: add 3.9 support and drop 3.5#167
busunkim96 merged 15 commits intomasterfrom
add-constraints-file

Conversation

@busunkim96
Copy link
Copy Markdown
Contributor

@busunkim96 busunkim96 commented Dec 4, 2020 •
edited
Loading

@busunkim96 busunkim96 requested a review from a team as a code owner December 4, 2020 00:56
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 4, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 4, 2020 •
edited
Loading

Codecov Report

Merging #167 (80802db) into master (5c14cba) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #167   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          862       862           
  Branches       149       149           
=========================================
  Hits           862       862

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c14cba...80802db. Read the comment docs.

@busunkim96 busunkim96 changed the title chore: add constraints file chore: add constraints file and 3.9 tests Dec 4, 2020
@busunkim96 busunkim96 changed the title chore: add constraints file and 3.9 tests feat: add 3.9 support and drop 3.5 Dec 4, 2020
@busunkim96
Copy link
Copy Markdown
Contributor Author

busunkim96 commented Dec 4, 2020

3.9 failures looks legitimate. Does some extra package need to be installed? @software-dov

https://app.circleci.com/pipelines/github/googleapis/proto-plus-python/409/workflows/059ae846-628f-498d-a500-68ca5ba92dca/jobs/3647/parallel-runs/0/steps/0-103?invite=true

nox > Running session unitcpp-3.9
nox > Creating virtual environment (virtualenv) using python3.9 in .nox/unitcpp-3-9
nox > pip install coverage pytest pytest-cov pytz
nox > pip install -e .[testing] -c /root/project/testing/constraints-3.9.txt
nox > py.test -W=error --quiet --cov=proto --cov-config=.coveragerc --cov-report=term --cov-report=html tests/
ImportError while loading conftest '/root/project/tests/conftest.py'.
tests/conftest.py:18: in <module>
    from google.protobuf import descriptor_pool
.nox/unitcpp-3-9/lib/python3.9/site-packages/google/protobuf/descriptor_pool.py:63: in <module>
    from google.protobuf import descriptor
.nox/unitcpp-3-9/lib/python3.9/site-packages/google/protobuf/descriptor.py:48: in <module>
    from google.protobuf.pyext import _message
E   ImportError: cannot import name '_message' from 'google.protobuf.pyext' (/root/project/.nox/unitcpp-3-9/lib/python3.9/site-packages/google/protobuf/pyext/__init__.py)
nox > Command py.test -W=error --quiet --cov=proto --cov-config=.coveragerc --cov-report=term --cov-report=html tests/ failed with exit code 4
nox > Session unitcpp-3.9 failed.

@software-dov
Copy link
Copy Markdown
Contributor

software-dov commented Dec 4, 2020

I ran into a similar problem when I initially tried running with 3.9; my best guess is that it's indicative of missing 3.9-specific protobuf C++ libs. We should double check with the python protobuf folks to see if that is an artifact that needs to be released.

@busunkim96
Copy link
Copy Markdown
Contributor Author

busunkim96 commented Dec 4, 2020

Looks like wheels are not yet published for 3.9. protocolbuffers/protobuf#7978

https://pypi.org/project/protobuf/3.14.0/#files has up through 3.8.

@busunkim96
Copy link
Copy Markdown
Contributor Author

busunkim96 commented Dec 4, 2020

I commented out the 3.9 C++ session for now.

@busunkim96 busunkim96 merged commit 6d17195 into master Dec 4, 2020
@busunkim96 busunkim96 deleted the add-constraints-file branch December 4, 2020 21:33
gcf-merge-on-green bot pushed a commit that referenced this pull request Dec 7, 2020
@release-please
chore: release 1.13.0 (#168)
ee74a03 
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.13.0](https://www.github.com/googleapis/proto-plus-python/compare/v1.12.0...v1.13.0) (2020-12-04)


### Features

* add 3.9 support and drop 3.5 ([#167](https://www.github.com/googleapis/proto-plus-python/issues/167)) ([6d17195](https://www.github.com/googleapis/proto-plus-python/commit/6d171956e14b398aece931b9dde1013be9644b74))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@crwilcox crwilcox crwilcox approved these changes

@software-dov software-dov software-dov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@busunkim96 @software-dov @crwilcox