Skip to content

Commit ea63cbe

Browse files
jirenstephenplusplus
authored andcommitted
fix(deps): upgrade @google-cloud/common version to show original… (#795)
* Version up for gc common to show original error message - Added system test case for non json response error * update to the latest version of @google-cloud/common
1 parent a8ceb78 commit ea63cbe

File tree

2 files changed

+29
-1
lines changed

2 files changed

+29
-1
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
"benchwrapper": "node bin/benchwrapper.js"
5252
},
5353
"dependencies": {
54-
"@google-cloud/common": "^2.0.0",
54+
"@google-cloud/common": "^2.1.0",
5555
"@google-cloud/paginator": "^2.0.0",
5656
"@google-cloud/promisify": "^1.0.0",
5757
"arrify": "^2.0.0",

system-test/storage.ts

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2008,6 +2008,34 @@ describe('storage', () => {
20082008
});
20092009
});
20102010

2011+
it('should thow orignal error message on non JSON response on large metadata', async () => {
2012+
const largeCustomMeta = (size: number) => {
2013+
let str = '';
2014+
for (let i = 0; i < size; i++) {
2015+
str += 'a';
2016+
}
2017+
return str;
2018+
};
2019+
2020+
const file = bucket.file('large-metadata-error-test');
2021+
// Save file with metadata size more then 2MB.
2022+
await assert.rejects(
2023+
async () => {
2024+
await file.save('test', {
2025+
resumable: false,
2026+
metadata: {
2027+
metadata: {
2028+
custom: largeCustomMeta(2.1e6),
2029+
},
2030+
},
2031+
});
2032+
},
2033+
{
2034+
message: 'Cannot parse response as JSON: Metadata part is too large.',
2035+
}
2036+
);
2037+
});
2038+
20112039
it('should read a byte range from a file', done => {
20122040
bucket.upload(FILES.big.path, (err: Error | null, file?: File | null) => {
20132041
assert.ifError(err);

0 commit comments

Comments
 (0)