fix(deps): upgrade @google-cloud/common version to show original error message #795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added system test case for non json response error
Codecov Report
@@ Coverage Diff @@
## master #795 +/- ##
=======================================
Coverage 94.96% 94.96%
=======================================
Files 10 10
Lines 1152 1152
Branches 288 288
=======================================
Hits 1094 1094
Misses 30 30
Partials 28 28Continue to review full report at Codecov.
|
38df9e4 to
e5fe9c9
Compare
stephenplusplus
approved these changes
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded
@google-cloud/commonhas added original error message with of JSON parsing failure.Fixes #170