feat(file): allow setting configPath of resumable upload (#642)

stephenplusplus · jkwlui · commit a8ceb789ae74 · 2019-08-07T09:36:42.000-07:00
* feat(file): allow setting configPath of resumable upload

* gts fix
diff --git a/src/file.ts b/src/file.ts
@@ -179,6 +179,7 @@ export type PredefinedAcl =
   | 'publicRead';
 
 export interface CreateResumableUploadOptions {
+  configPath?: string;
   metadata?: Metadata;
   origin?: string;
   offset?: number;
@@ -1426,6 +1427,10 @@ class File extends ServiceObject<File> {
    */
   /**
    * @typedef {object} CreateResumableUploadOptions
+   * @property {string} [configPath] Where the `gcs-resumable-upload`
+   *     configuration file should be stored on your system. This maps to the
+   *     [configstore option by the same
+   * name](https://github.com/yeoman/configstore/tree/0df1ec950d952b1f0dfb39ce22af8e505dffc71a#configpath).
    * @property {object} [metadata] Metadata to set on the file.
    * @property {string} [origin] Origin header to set for the upload.
    * @property {string} [predefinedAcl] Apply a predefined set of access
@@ -1509,6 +1514,7 @@ class File extends ServiceObject<File> {
       {
         authClient: this.storage.authClient,
         bucket: this.bucket.name,
+        configPath: options.configPath,
         file: this.name,
         generation: this.generation,
         key: this.encryptionKey,
@@ -1527,6 +1533,10 @@ class File extends ServiceObject<File> {
 
   /**
    * @typedef {object} CreateWriteStreamOptions Configuration options for File#createWriteStream().
+   * @property {string} [configPath] **This only applies to resumable
+   *     uploads.** Where the `gcs-resumable-upload` configuration file should
+   * be stored on your system. This maps to the [configstore option by the same
+   * name](https://github.com/yeoman/configstore/tree/0df1ec950d952b1f0dfb39ce22af8e505dffc71a#configpath).
    * @property {string} [contentType] Alias for
    *     `options.metadata.contentType`. If set to `auto`, the file name is used
    *     to determine the contentType.
@@ -3257,6 +3267,7 @@ class File extends ServiceObject<File> {
     const uploadStream = resumableUpload.upload({
       authClient: this.storage.authClient,
       bucket: this.bucket.name,
+      configPath: options.configPath,
       file: this.name,
       generation: this.generation,
       key: this.encryptionKey,
diff --git a/test/file.ts b/test/file.ts
@@ -1511,6 +1511,7 @@ describe('File', () => {
 
     it('should create a resumable upload URI', done => {
       const options = {
+        configPath: '/Users/user/.config/here',
         metadata: {
           contentType: 'application/json',
         },
@@ -1533,6 +1534,7 @@ describe('File', () => {
 
           assert.strictEqual(opts.authClient, storage.authClient);
           assert.strictEqual(opts.bucket, bucket.name);
+          assert.strictEqual(opts.configPath, options.configPath);
           assert.strictEqual(opts.file, file.name);
           assert.strictEqual(opts.generation, file.generation);
           assert.strictEqual(opts.key, file.encryptionKey);
@@ -3671,6 +3673,7 @@ describe('File', () => {
     describe('starting', () => {
       it('should start a resumable upload', done => {
         const options = {
+          configPath: '/Users/user/.config/here',
           metadata: {},
           offset: 1234,
           public: true,
@@ -3693,6 +3696,7 @@ describe('File', () => {
 
             assert.strictEqual(opts.authClient, authClient);
             assert.strictEqual(opts.bucket, bucket.name);
+            assert.strictEqual(opts.configPath, options.configPath);
             assert.strictEqual(opts.file, file.name);
             assert.strictEqual(opts.generation, file.generation);
             assert.strictEqual(opts.key, file.encryptionKey);
