Skip to content

feat(file): allow setting configPath of resumable upload #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkwlui merged 10 commits into from
Aug 7, 2019
Merged

feat(file): allow setting configPath of resumable upload #642

jkwlui merged 10 commits into from
Aug 7, 2019

Conversation

@stephenplusplus
Copy link
Contributor

@stephenplusplus stephenplusplus commented Mar 26, 2019 •
edited
Loading

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 26, 2019
@stephenplusplus stephenplusplus added status: blocked Resolving the issue is dependent on other work. do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Mar 26, 2019
@codecov
Copy link

codecov bot commented Mar 26, 2019 •
edited
Loading

Codecov Report

Merging #642 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #642   +/-   ##
=======================================
  Coverage   97.94%   97.94%           
=======================================
  Files           9        9           
  Lines         874      874           
  Branches       99       99           
=======================================
  Hits          856      856           
  Misses          9        9           
  Partials        9        9
Impacted Files Coverage Δ
src/file.ts 98.64% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51370df...8e551f8. Read the comment docs.

@stephenplusplus
Copy link
Contributor Author

stephenplusplus commented Mar 27, 2019

We actually don't want to merge this yet, as I think we are rolling back gcs-resumable-upload to pre 1.0.

jkwlui
jkwlui suggested changes Mar 27, 2019
View reviewed changes
Copy link
Member

@jkwlui jkwlui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not merge yet.

@codecov
Copy link

codecov bot commented Mar 27, 2019 •
edited
Loading

Codecov Report

Merging #642 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #642   +/-   ##
=======================================
  Coverage   94.96%   94.96%           
=======================================
  Files          10       10           
  Lines        1152     1152           
  Branches      288      288           
=======================================
  Hits         1094     1094           
  Misses         30       30           
  Partials       28       28
Impacted Files Coverage Δ
src/file.ts 98.12% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1146b5e...681b06e. Read the comment docs.

@JustinBeckwith
Copy link
Contributor

JustinBeckwith commented Apr 4, 2019

@jkwlui @stephenplusplus this is getting a tad moldy. Do we have clear steps to get it merged?

@JustinBeckwith
Copy link
Contributor

JustinBeckwith commented Apr 12, 2019

@stephenplusplus @jkwlui I'm going to close this out for now.

@stephenplusplus stephenplusplus removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. status: blocked Resolving the issue is dependent on other work. labels Aug 2, 2019
@stephenplusplus stephenplusplus requested a review from jkwlui August 2, 2019 23:38
@stephenplusplus
Copy link
Contributor Author

stephenplusplus commented Aug 2, 2019

@jkwlui @JustinBeckwith this one should be ready to go now. Please take a look!

@jkwlui jkwlui merged commit a8ceb78 into googleapis:master Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@jkwlui jkwlui jkwlui approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Creating a resumable upload from chunks

4 participants

@stephenplusplus @JustinBeckwith @jkwlui @googlebot