This repository was archived by the owner on Mar 4, 2026. It is now read-only.
perf: increase default min sessions to 25#1167
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1167 +/- ##
==========================================
+ Coverage 98.12% 98.23% +0.10%
==========================================
Files 23 23
Lines 20996 21033 +37
Branches 1153 1156 +3
==========================================
+ Hits 20603 20662 +59
+ Misses 388 368 -20
+ Partials 5 3 -2
Continue to review full report at Codecov.
|
skuruppu
approved these changes
Jul 7, 2020
skuruppu
left a comment
Contributor
There was a problem hiding this comment.
Thanks so much for this change.
Co-authored-by: skuruppu <skuruppu@google.com>
Co-authored-by: skuruppu <skuruppu@google.com>
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Jul 7, 2020
🤖 I have created a release \*beep\* \*boop\* --- ### [5.2.1](https://www.github.com/googleapis/nodejs-spanner/compare/v5.2.0...v5.2.1) (2020-07-07) ### Bug Fixes * remove error listener to prevent memory leak ([#1168](https://www.github.com/googleapis/nodejs-spanner/issues/1168)) ([523bd67](https://www.github.com/googleapis/nodejs-spanner/commit/523bd67ed6d5ecbfe9abce0f1b6ed4cce2c07b30)) ### Performance Improvements * increase default min sessions to 25 ([#1167](https://www.github.com/googleapis/nodejs-spanner/issues/1167)) ([e4aba27](https://www.github.com/googleapis/nodejs-spanner/commit/e4aba27d307e5932b223121af5bea37a7418bb20)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase the default setting of
SessionPoolOptions.minto 25.Fixes #1160