fix: provide missing close() method in the generated gapic client #941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…escript gapic generator
…r_client.js to match it
alexander-fenster
approved these changes
Apr 6, 2020
JustinBeckwith
approved these changes
Apr 6, 2020
Contributor
JustinBeckwith
left a comment
There was a problem hiding this comment.
Please file a bug to come back and clean this up as part of the microgenerator / node10 upgrade!
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Apr 6, 2020
🤖 I have created a release \*beep\* \*boop\* --- ### [1.7.1](https://www.github.com/googleapis/nodejs-pubsub/compare/v1.7.0...v1.7.1) (2020-04-06) ### Bug Fixes * provide missing close() method in the generated gapic client ([#941](https://www.github.com/googleapis/nodejs-pubsub/issues/941)) ([6bf8f14](https://www.github.com/googleapis/nodejs-pubsub/commit/6bf8f1481a1dea051c47697488e13b6facf20a26)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #937
The issue is that our TypeScript gapic generator provides a close() method, but the old JavaScript one doesn't seem to. So the close() feature addition was relying on some invalid typings. I've backported that for publisher client, and added a system-test that will hopefully catch future issues.
Going forward, the TypeScript gapic upgrade is definitely the right fix here, but that's also going to bump us up to Node 10+, so I want to fix this existing feature first.