revert!: remove pullTimeout subscriber option (#618)

callmehiphop · web-flow · commit 4fc97241daef · 2019-05-20T16:22:53.000-07:00
diff --git a/src/message-stream.ts b/src/message-stream.ts
@@ -48,7 +48,6 @@ const PULL_TIMEOUT = require('./v1/subscriber_client_config.json').interfaces[
 const DEFAULT_OPTIONS: MessageStreamOptions = {
   highWaterMark: 0,
   maxStreams: 5,
-  pullTimeout: PULL_TIMEOUT,
   timeout: 300000,
 };
 
@@ -103,15 +102,11 @@ export class ChannelError extends Error implements ServiceError {
  *     {@link https://nodejs.org/en/docs/guides/backpressuring-in-streams/} for
  *     more details.
  * @property {number} [maxStreams=5] Number of streaming connections to make.
- * @property {number} [pullTimeout=900000] Timeout to be applied to each
- *     underlying stream. Essentially this just closes a `StreamingPull` request
- *     after the specified time.
  * @property {number} [timeout=300000] Timeout for establishing a connection.
  */
 export interface MessageStreamOptions {
   highWaterMark?: number;
   maxStreams?: number;
-  pullTimeout?: number;
   timeout?: number;
 }
 
@@ -223,7 +218,7 @@ export class MessageStream extends PassThrough {
       return;
     }
 
-    const deadline = Date.now() + this._options.pullTimeout!;
+    const deadline = Date.now() + PULL_TIMEOUT;
     const request: StreamingPullRequest = {
       subscription: this._subscriber.name,
       streamAckDeadlineSeconds: this._subscriber.ackDeadline,
diff --git a/test/message-stream.ts b/test/message-stream.ts
@@ -270,21 +270,6 @@ describe('MessageStream', () => {
           });
         });
 
-        it('should respect the pullTimeout option', done => {
-          const pullTimeout = 1234;
-          const expectedDeadline = now + pullTimeout;
-
-          messageStream = new MessageStream(subscriber, {pullTimeout});
-
-          setImmediate(() => {
-            client.streams.forEach(stream => {
-              const deadline = stream.options.deadline;
-              assert.strictEqual(deadline, expectedDeadline);
-            });
-            done();
-          });
-        });
-
         it('should respect the timeout option', done => {
           const timeout = 12345;
           const expectedDeadline = now + timeout;
