revert!: remove pullTimeout subscriber option #618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #618 +/- ##
=======================================
Coverage 97.89% 97.89%
=======================================
Files 14 14
Lines 857 857
Branches 178 178
=======================================
Hits 839 839
Misses 2 2
Partials 16 16
Continue to review full report at Codecov.
|
bcoe
approved these changes
May 20, 2019
bcoe
left a comment
There was a problem hiding this comment.
LGTM 👍
Do I gather that pullTimeout was added in an attempt to address a specific user's problem, and it ultimately wasn't needed?
Contributor
Author
|
@bcoe yeah, that is pretty much the gist of why |
Closed
Closed
Closed
Merged
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #468 (comment)
The PubSub team would prefer that we do not provide this option.