Skip to content
This repository was archived by the owner on Mar 11, 2026. It is now read-only.

fix: Cannot read property 'forEach' of undefined#1173

Merged
losalex merged 3 commits into
mainfrom
losalex/fix-1113
Oct 29, 2021
Merged

fix: Cannot read property 'forEach' of undefined#1173
losalex merged 3 commits into
mainfrom
losalex/fix-1113

Conversation

@losalex

@losalex losalex commented Oct 29, 2021

Copy link
Copy Markdown
Contributor

Remove the try/catch which ignores error when decoratedEntries cannot be converted and remain undefined, thus failing on later stage since forEach cannot be used with undefined. This will make sure that real error will be revealed and hence can be addressed.

Fixes #1113 🦕

@losalex losalex requested review from a team October 29, 2021 18:02
@product-auto-label product-auto-label Bot added the api: logging Issues related to the googleapis/nodejs-logging API. label Oct 29, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 29, 2021
@keenan-devrel keenan-devrel added priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern. labels Oct 29, 2021
@losalex losalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 29, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 29, 2021
@losalex losalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 29, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 29, 2021
@losalex losalex added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 29, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 29, 2021
@losalex losalex merged commit abf1ab0 into main Oct 29, 2021
@losalex losalex deleted the losalex/fix-1113 branch October 29, 2021 22:31
gcf-merge-on-green Bot pushed a commit that referenced this pull request Nov 1, 2021
@release-please
chore: release 9.6.2 (#1174)
97bc9c9 
🤖 I have created a release \*beep\* \*boop\*
---
### [9.6.2](https://www.github.com/googleapis/nodejs-logging/compare/v9.6.1...v9.6.2) (2021-11-01)


### Bug Fixes

* Cannot read property 'forEach' of undefined ([#1173](https://www.github.com/googleapis/nodejs-logging/issues/1173)) ([abf1ab0](https://www.github.com/googleapis/nodejs-logging/commit/abf1ab03483db8bf0c018524c348260a06193a4c))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@daniel-sanche daniel-sanche daniel-sanche approved these changes

@simonz130 simonz130 simonz130 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@losalex losalex

Labels

api: logging Issues related to the googleapis/nodejs-logging API. cla: yes This human has signed the Contributor License Agreement. priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot read property 'forEach' of undefined

5 participants

@losalex @daniel-sanche @simonz130 @yoshi-kokoro @keenan-devrel