Skip to content

fix: export ErrorMessage as part of the package #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
minherz merged 1 commit into from
Oct 4, 2021
Merged

fix: export ErrorMessage as part of the package #604

minherz merged 1 commit into from
Oct 4, 2021

Conversation

@minherz
Copy link
Contributor

@minherz minherz commented Oct 1, 2021

Explicitly exports ErrorMessage class.

Fixes #584

@minherz minherz requested review from a team as code owners October 1, 2021 10:15
@product-auto-label product-auto-label bot added the api: clouderrorreporting Issues related to the googleapis/nodejs-error-reporting API. label Oct 1, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 1, 2021
@minherz minherz assigned minherz and unassigned simonz130 Oct 1, 2021
losalex
losalex approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@losalex losalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

losalex
losalex approved these changes Oct 3, 2021
View reviewed changes
Copy link
Contributor

@losalex losalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minherz minherz merged commit eeb0218 into main Oct 4, 2021
@minherz minherz deleted the minherz/fix-584 branch October 4, 2021 07:07
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 4, 2021
@release-please
chore: release 2.0.4 (#605)
88ffebb 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.0.4](https://www.github.com/googleapis/nodejs-error-reporting/compare/v2.0.3...v2.0.4) (2021-10-04)


### Bug Fixes

* export ErrorMessage as part of the package ([#604](https://www.github.com/googleapis/nodejs-error-reporting/issues/604)) ([eeb0218](https://www.github.com/googleapis/nodejs-error-reporting/commit/eeb02180691260960438b1fbb42425843aa2d677)), closes [#584](https://www.github.com/googleapis/nodejs-error-reporting/issues/584)
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@losalex losalex losalex approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@minherz minherz

Labels

api: clouderrorreporting Issues related to the googleapis/nodejs-error-reporting API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Export ErrorMessage from index.ts?

3 participants

@minherz @losalex @simonz130