This repository was archived by the owner on Jul 20, 2023. It is now read-only.
fix: specify valid go_package option #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The explicitly specified package name is invalid since it identical to one of the keywords in Go (e.g., "package" or "type"). Remove explicitly specifying the name, which will cause protoc-gen-go to derive the package name from the last path segment. If the name is not valid, it will automatically sanitize it to produce a valid package identifier (e.g., "_package" or "_type"). Committer: @dsnet PiperOrigin-RevId: 370589666 Source-Link: googleapis/googleapis@e7d77d6 Source-Link: https://github.com/googleapis/googleapis-gen/commit/b6ec2fd12e44091f07ae9b99dc12879898bd6fb7
Codecov Report
@@ Coverage Diff @@
## master #293 +/- ##
=======================================
Coverage 96.82% 96.82%
=======================================
Files 8 8
Lines 4128 4128
Branches 181 181
=======================================
Hits 3997 3997
Misses 128 128
Partials 3 3 Continue to review full report at Codecov.
|
SurferJeffAtGoogle
approved these changes
Apr 27, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Apr 28, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [3.1.1](https://www.github.com/googleapis/nodejs-containeranalysis/compare/v3.1.0...v3.1.1) (2021-04-27) ### Bug Fixes * specify valid go_package option ([#293](https://www.github.com/googleapis/nodejs-containeranalysis/issues/293)) ([84ba201](https://www.github.com/googleapis/nodejs-containeranalysis/commit/84ba201c2d2eb81faf36461cf1ff3bfccf33f5ed)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The explicitly specified package name is invalid since it identical
to one of the keywords in Go (e.g., "package" or "type").
Remove explicitly specifying the name, which will cause protoc-gen-go
to derive the package name from the last path segment.
If the name is not valid, it will automatically sanitize it
to produce a valid package identifier (e.g., "_package" or "_type").
Committer: @dsnet
PiperOrigin-RevId: 370589666
Source-Link: googleapis/googleapis@e7d77d6
Source-Link: https://github.com/googleapis/googleapis-gen/commit/b6ec2fd12e44091f07ae9b99dc12879898bd6fb7