Merged
Conversation
Common protos do not belong here, they are a part of google-gax.
Codecov Report
@@ Coverage Diff @@
## master #853 +/- ##
=======================================
Coverage 99.22% 99.22%
=======================================
Files 18 18
Lines 17424 17424
Branches 1025 952 -73
=======================================
Hits 17289 17289
Misses 132 132
Partials 3 3 Continue to review full report at Codecov.
|
JustinBeckwith
approved these changes
Mar 17, 2021
Contributor
JustinBeckwith
left a comment
There was a problem hiding this comment.
I'm kind of curious .... how did these end up here?
Contributor
|
ok woah this was a pre-gax thing |
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Apr 28, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [3.3.1](https://www.github.com/googleapis/nodejs-bigtable/compare/v3.3.0...v3.3.1) (2021-04-20) ### Bug Fixes * remove common protos ([#853](https://www.github.com/googleapis/nodejs-bigtable/issues/853)) ([d08f481](https://www.github.com/googleapis/nodejs-bigtable/commit/d08f4816205dd5562c280779d5f4c6708cb792be)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Common protos do not belong here, they are a part of google-gax.