fix: KMS Bad Key error when using existing Blob context to overwrite object#507
Merged
frankyn merged 7 commits intogoogleapis:masterfrom Sep 17, 2020
Merged
fix: KMS Bad Key error when using existing Blob context to overwrite object#507frankyn merged 7 commits intogoogleapis:masterfrom
frankyn merged 7 commits intogoogleapis:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #507 +/- ##
============================================
- Coverage 64.69% 64.68% -0.02%
+ Complexity 629 620 -9
============================================
Files 32 32
Lines 5249 5255 +6
Branches 509 511 +2
============================================
+ Hits 3396 3399 +3
- Misses 1694 1697 +3
Partials 159 159
Continue to review full report at Codecov.
|
frankyn
suggested changes
Sep 14, 2020
frankyn
reviewed
Sep 15, 2020
frankyn
reviewed
Sep 17, 2020
Contributor
Author
|
@frankyn PTAL |
frankyn
reviewed
Sep 17, 2020
| Builder setKmsKeyName(String kmsKeyName) { | ||
| this.kmsKeyName = kmsKeyName; | ||
| this.kmsKeyName = | ||
| kmsKeyName != null && kmsKeyName.contains("cryptoKeyVersions") ? "" : kmsKeyName; |
Contributor
There was a problem hiding this comment.
This change should be in the HttpStorageRpc request being sent instead.
frankyn
approved these changes
Sep 17, 2020
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Sep 17, 2020
🤖 I have created a release \*beep\* \*boop\* --- ### [1.113.1](https://www.github.com/googleapis/java-storage/compare/v1.113.0...v1.113.1) (2020-09-17) ### Bug Fixes * KMS Bad Key error when using existing Blob context to overwrite object ([#507](https://www.github.com/googleapis/java-storage/issues/507)) ([4d9c490](https://www.github.com/googleapis/java-storage/commit/4d9c49027e4746ee273902694441886c2f43188d)) * When passing a sub-array (offset, length) to the Storage#create method the array is needlessly cloned ([#506](https://www.github.com/googleapis/java-storage/issues/506)) ([9415bb7](https://www.github.com/googleapis/java-storage/commit/9415bb7bdb42d8012ca457a90070b616e6bbec19)), closes [#505](https://www.github.com/googleapis/java-storage/issues/505) ### Dependencies * update dependency com.google.apis:google-api-services-storage to v1-rev20200814-1.30.10 ([#499](https://www.github.com/googleapis/java-storage/issues/499)) ([af91d7d](https://www.github.com/googleapis/java-storage/commit/af91d7da4117fb22992d6a860af61f72906e0aa1)) ### Documentation * update libraries-bom ([#504](https://www.github.com/googleapis/java-storage/issues/504)) ([0e58c1c](https://www.github.com/googleapis/java-storage/commit/0e58c1cb2b6a890e567b043188613021592f2bc8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #502