fix: client.close() should wait until the channels are terminated before shutting down the executor #916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore shutting down the executor Previously the client.close() would simply shutdown the channel pool and the executor immediately after. Unfortunately this leads to RPCs that would hang forever because an outstanding RPC didnt have an executor to notify of its completion. This PR ensures that the channels are drained before shutting down the executor
mutianf
approved these changes
Jul 19, 2021
...loud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java
Show resolved
Hide resolved
kolea2
pushed a commit
to kolea2/java-bigtable
that referenced
this pull request
Sep 9, 2021
…ore shutting down the executor (googleapis#916) * fix: client.close() should wait until the channels are terminated before shutting down the executor Previously the client.close() would simply shutdown the channel pool and the executor immediately after. Unfortunately this leads to RPCs that would hang forever because an outstanding RPC didnt have an executor to notify of its completion. This PR ensures that the channels are drained before shutting down the executor * copyright (cherry picked from commit 914f0cc)
kolea2
added a commit
that referenced
this pull request
Sep 10, 2021
…ore shutting down the executor (#916) (#1000) * fix: client.close() should wait until the channels are terminated before shutting down the executor Previously the client.close() would simply shutdown the channel pool and the executor immediately after. Unfortunately this leads to RPCs that would hang forever because an outstanding RPC didnt have an executor to notify of its completion. This PR ensures that the channels are drained before shutting down the executor * copyright (cherry picked from commit 914f0cc) Co-authored-by: Igor Bernstein <igorbernstein@google.com>
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 10, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.22.0-sp.2](https://www.github.com/googleapis/java-bigtable/compare/1.22.0-sp.1...v1.22.0-sp.2) (2021-09-10) ### Bug Fixes * client.close() should wait until the channels are terminated before shutting down the executor ([#916](https://www.github.com/googleapis/java-bigtable/issues/916)) ([#1000](https://www.github.com/googleapis/java-bigtable/issues/1000)) ([2c6b2cb](https://www.github.com/googleapis/java-bigtable/commit/2c6b2cb2d163650747731a623880f9ba368b4a55)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the client.close() would simply shutdown the channel pool and the executor immediately after. Unfortunately this leads to RPCs that would hang forever because an outstanding RPC didnt have an executor to notify of its completion. This PR ensures that the channels are drained before shutting down the executor