Skip to content

feat: backup level IAM#450

Merged
kolea2 merged 5 commits intogoogleapis:masterfrom
kolea2:backup-level-iam
Oct 21, 2020
Merged

feat: backup level IAM#450
kolea2 merged 5 commits intogoogleapis:masterfrom
kolea2:backup-level-iam

Conversation

@kolea2
Copy link
Copy Markdown
Contributor

@kolea2 kolea2 commented Oct 7, 2020 •
edited
Loading

@kolea2 kolea2 requested a review from a team October 7, 2020 19:26
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 7, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 7, 2020 •
edited
Loading

Codecov Report

Merging #450 into master will increase coverage by 21.83%.
The diff coverage is 82.85%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master     #450       +/-   ##
=============================================
+ Coverage     59.20%   81.03%   +21.83%     
- Complexity       19     1124     +1105     
=============================================
  Files             2      105      +103     
  Lines           125     6956     +6831     
  Branches         18      369      +351     
=============================================
+ Hits             74     5637     +5563     
- Misses           34     1120     +1086     
- Partials         17      199      +182
Impacted Files Coverage Δ Complexity Δ
...ud/bigtable/admin/v2/BigtableTableAdminClient.java 84.58% <82.85%> (ø) 44.00 <8.00> (?)
...able/gaxx/reframing/ReframingResponseObserver.java 89.28% <0.00%> (ø) 29.00% <0.00%> (?%)
...le/cloud/bigtable/data/v2/models/BulkMutation.java 97.56% <0.00%> (ø) 10.00% <0.00%> (?%)
...gle/cloud/bigtable/admin/v2/models/AppProfile.java 60.34% <0.00%> (ø) 11.00% <0.00%> (?%)
...google/cloud/bigtable/data/v2/models/Mutation.java 87.09% <0.00%> (ø) 28.00% <0.00%> (?%)
...bigtable/admin/v2/models/CreateClusterRequest.java 95.45% <0.00%> (ø) 8.00% <0.00%> (?%)
...table/admin/v2/BaseBigtableTableAdminSettings.java 8.75% <0.00%> (ø) 2.00% <0.00%> (?%)
...d/bigtable/gaxx/retrying/NonCancellableFuture.java 16.66% <0.00%> (ø) 1.00% <0.00%> (?%)
...able/admin/v2/stub/GrpcBigtableTableAdminStub.java 96.52% <0.00%> (ø) 29.00% <0.00%> (?%)
.../bigtable/admin/v2/models/UpdateBackupRequest.java 80.55% <0.00%> (ø) 7.00% <0.00%> (?%)
... and 95 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 346a42d...f32d903. Read the comment docs.

@product-auto-label product-auto-label Bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Oct 8, 2020
@kolea2 kolea2 requested a review from igorbernstein2 October 9, 2020 15:33
@quartzmo quartzmo mentioned this pull request Oct 14, 2020
Closed
igorbernstein2
igorbernstein2 approved these changes Oct 21, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kolea2 kolea2 merged commit f38a8ec into googleapis:master Oct 21, 2020
@kolea2 kolea2 deleted the backup-level-iam branch October 21, 2020 17:38
gcf-merge-on-green Bot pushed a commit that referenced this pull request Oct 23, 2020
@release-please
chore: release 1.17.0 (#478)
d0f21a2 
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.17.0](https://www.github.com/googleapis/java-bigtable/compare/v1.16.2...v1.17.0) (2020-10-23)


### Features

* attemp DirectPath by default ([#467](https://www.github.com/googleapis/java-bigtable/issues/467)) ([89c622d](https://www.github.com/googleapis/java-bigtable/commit/89c622da6038067892687af3edafae743465eda7))
* backup level IAM ([#450](https://www.github.com/googleapis/java-bigtable/issues/450)) ([f38a8ec](https://www.github.com/googleapis/java-bigtable/commit/f38a8ecdc6164d081ef96f748ea37bd62b29b419))
* Implement toString for Bigtable*Settings ([#488](https://www.github.com/googleapis/java-bigtable/issues/488)) ([4d821f8](https://www.github.com/googleapis/java-bigtable/commit/4d821f85ceb237c8e449243ff8c80fb94e22ad51))


### Bug Fixes

* Make refreshing channel compatible with BigtableDataClientFactory ([#474](https://www.github.com/googleapis/java-bigtable/issues/474)) ([fc74164](https://www.github.com/googleapis/java-bigtable/commit/fc741645536e01fac772136bc8346f73ff95e600))


### Documentation

* fix formatting ([#476](https://www.github.com/googleapis/java-bigtable/issues/476)) ([eb24569](https://www.github.com/googleapis/java-bigtable/commit/eb24569e53f9d2b7fde50748c840c2c11f3f3c80))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.12.1 ([#475](https://www.github.com/googleapis/java-bigtable/issues/475)) ([9e56edf](https://www.github.com/googleapis/java-bigtable/commit/9e56edfa7b0a78f14518a99130a7b319c5873be4))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.13.0 ([#484](https://www.github.com/googleapis/java-bigtable/issues/484)) ([aad648f](https://www.github.com/googleapis/java-bigtable/commit/aad648fec16b122092d394350822da742a2d7aa0))
* update dependency com.google.truth:truth to v1.1 ([#483](https://www.github.com/googleapis/java-bigtable/issues/483)) ([cca1e0e](https://www.github.com/googleapis/java-bigtable/commit/cca1e0e16f2ec0cc887d81c1844f5395ce08b6ea))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
ad548 pushed a commit to ad548/java-bigtable that referenced this pull request Mar 13, 2021
@kolea2 @ad548
feat: backup level IAM (googleapis#450)
450d9dd 
* feat: backup level IAM

* docs

* extract out common logic

* code feedback

* lint
ad548 pushed a commit to ad548/java-bigtable that referenced this pull request Mar 13, 2021
@release-please @ad548
chore: release 1.17.0 (googleapis#478)
558c8f6 
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.17.0](https://www.github.com/googleapis/java-bigtable/compare/v1.16.2...v1.17.0) (2020-10-23)


### Features

* attemp DirectPath by default ([googleapis#467](https://www.github.com/googleapis/java-bigtable/issues/467)) ([89c622d](https://www.github.com/googleapis/java-bigtable/commit/89c622da6038067892687af3edafae743465eda7))
* backup level IAM ([googleapis#450](https://www.github.com/googleapis/java-bigtable/issues/450)) ([f38a8ec](https://www.github.com/googleapis/java-bigtable/commit/f38a8ecdc6164d081ef96f748ea37bd62b29b419))
* Implement toString for Bigtable*Settings ([googleapis#488](https://www.github.com/googleapis/java-bigtable/issues/488)) ([4d821f8](https://www.github.com/googleapis/java-bigtable/commit/4d821f85ceb237c8e449243ff8c80fb94e22ad51))


### Bug Fixes

* Make refreshing channel compatible with BigtableDataClientFactory ([googleapis#474](https://www.github.com/googleapis/java-bigtable/issues/474)) ([fc74164](https://www.github.com/googleapis/java-bigtable/commit/fc741645536e01fac772136bc8346f73ff95e600))


### Documentation

* fix formatting ([googleapis#476](https://www.github.com/googleapis/java-bigtable/issues/476)) ([eb24569](https://www.github.com/googleapis/java-bigtable/commit/eb24569e53f9d2b7fde50748c840c2c11f3f3c80))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.12.1 ([googleapis#475](https://www.github.com/googleapis/java-bigtable/issues/475)) ([9e56edf](https://www.github.com/googleapis/java-bigtable/commit/9e56edfa7b0a78f14518a99130a7b319c5873be4))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.13.0 ([googleapis#484](https://www.github.com/googleapis/java-bigtable/issues/484)) ([aad648f](https://www.github.com/googleapis/java-bigtable/commit/aad648fec16b122092d394350822da742a2d7aa0))
* update dependency com.google.truth:truth to v1.1 ([googleapis#483](https://www.github.com/googleapis/java-bigtable/issues/483)) ([cca1e0e](https://www.github.com/googleapis/java-bigtable/commit/cca1e0e16f2ec0cc887d81c1844f5395ce08b6ea))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kolea2 @igorbernstein2