Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

docs: user-provided streamOrTableName for default write streams#1155

Merged
stephaniewang526 merged 3 commits intomasterfrom
default-stream
Jun 29, 2021
Merged

docs: user-provided streamOrTableName for default write streams#1155
stephaniewang526 merged 3 commits intomasterfrom
default-stream

Conversation

@anguillanneuf
Copy link
Copy Markdown
Contributor

@anguillanneuf anguillanneuf commented Jun 29, 2021 •
edited
Loading

Fixes a broken URL in a sample comment.

Also cleans up the docstrings for streamOrTableName in JsonStreamWriter.Builder.

IIUC, createDefaultStream can only be set to True on StreamWriter not JsonStreamWriter, the language below could mislead devs into thinking otherwise because it's not clear which builder it refers to.

java-bigquerystorage/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/JsonStreamWriter.java

Lines 185 to 188 in d6c3146

* @param streamOrTableName name of the stream that must follow
* "projects/[^/]+/datasets/[^/]+/tables/[^/]+/streams/[^/]+" or if it is default stream
* (createDefaultStream is true on builder), then the name here should be a table name
* ""projects/[^/]+/datasets/[^/]+/tables/[^/]+"

Also it looks like _default is not added by client code but by the library.

java-bigquerystorage/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/JsonStreamWriter.java

Lines 267 to 274 in d6c3146

private Builder(String streamOrTableName, TableSchema tableSchema, BigQueryWriteClient client) {
Matcher streamMatcher = streamPattern.matcher(streamOrTableName);
if (!streamMatcher.matches()) {
Matcher tableMatcher = tablePattern.matcher(streamOrTableName);
if (!tableMatcher.matches()) {
throw new IllegalArgumentException("Invalid name: " + streamOrTableName);
} else {
this.streamName = streamOrTableName + "/_default";

Not sure if I'm making all the right calls here. Thanks for reviewing!

Also see internal cl/381977832.

@anguillanneuf anguillanneuf requested review from a team and tswast June 29, 2021 16:49
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 29, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Jun 29, 2021
@stephaniewang526
Copy link
Copy Markdown
Contributor

stephaniewang526 commented Jun 29, 2021

Thank you!

@stephaniewang526 stephaniewang526 merged commit fc4a5c0 into master Jun 29, 2021
@stephaniewang526 stephaniewang526 deleted the default-stream branch June 29, 2021 17:55
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 30, 2021
@release-please
chore: release 1.22.6 (#1157)
f0f66bf 
🤖 I have created a release \*beep\* \*boop\*
---
### [1.22.6](https://www.github.com/googleapis/java-bigquerystorage/compare/v1.22.5...v1.22.6) (2021-06-30)


### Documentation

* **sample:** add IT for WriteToDefaultStream ([#1158](https://www.github.com/googleapis/java-bigquerystorage/issues/1158)) ([3280d7a](https://www.github.com/googleapis/java-bigquerystorage/commit/3280d7a0495a25f2509c9d4719439253e0fbaa5d)), closes [#1156](https://www.github.com/googleapis/java-bigquerystorage/issues/1156)
* user-provided streamOrTableName for default write streams ([#1155](https://www.github.com/googleapis/java-bigquerystorage/issues/1155)) ([fc4a5c0](https://www.github.com/googleapis/java-bigquerystorage/commit/fc4a5c061f51d83e41109ebf04f4202276410e30))


### Dependencies

* update dependency com.google.cloud:google-cloud-bigquery to v1.135.1 ([#1154](https://www.github.com/googleapis/java-bigquerystorage/issues/1154)) ([99f8ebb](https://www.github.com/googleapis/java-bigquerystorage/commit/99f8ebb2fde1fd86315a03dea5719e7a7744d081))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v1.4.0 ([#1159](https://www.github.com/googleapis/java-bigquerystorage/issues/1159)) ([7e1b206](https://www.github.com/googleapis/java-bigquerystorage/commit/7e1b2062f8cb13c05270d86c9ff6863934e7478d))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
@release-please
chore(main): release 0.126.12 (googleapis#1155)
da6d5e6 
🤖 I have created a release *beep* *boop*
---


## [0.126.12](https://togithub.com/googleapis/java-storage-nio/compare/v0.126.11...v0.126.12) (2023-04-12)


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.7.0 ([googleapis#1154](https://togithub.com/googleapis/java-storage-nio/issues/1154)) ([1e1590d](https://togithub.com/googleapis/java-storage-nio/commit/1e1590de0dee2d2d2dc995978460d1dedec30799))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tswast tswast Awaiting requested review from tswast

1 more reviewer

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@stephaniewang526 stephaniewang526

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anguillanneuf @stephaniewang526