docs(samples): create and query Amazon s3 data using external table#835
Conversation
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #835 +/- ##
=========================================
Coverage 80.37% 80.37%
Complexity 1268 1268
=========================================
Files 79 79
Lines 6548 6548
Branches 749 749
=========================================
Hits 5263 5263
Misses 892 892
Partials 393 393 Continue to review full report at Codecov.
|
samples/snippets/src/main/java/com/example/bigquery/QueryExternalTableAws.java
Show resolved
Hide resolved
| } catch (BigQueryException | InterruptedException e) { | ||
| System.out.println("Query not performed \n" + e.toString()); | ||
| } |
There was a problem hiding this comment.
Should these be caught? Perhaps just mention them or let them propagate? NOTE - BigQueryException is a RuntimeException and InterruptedException is not.
There was a problem hiding this comment.
More important is why might these have been thrown and what should a user really do with them?
There was a problem hiding this comment.
I think we will catch BigQueryException and not InterruptedException.
Updated!
| @Test | ||
| public void testCreateExternalTableAws() { | ||
| String sourceUri = "s3://cloud-samples-tests/us-states.csv"; | ||
| String sourceUri = "s3://steph-omni-test-bucket/us-states.csv"; |
There was a problem hiding this comment.
Might not be your best final choice for a bucket name.
There was a problem hiding this comment.
Yes - you're right. Created a new bucket for devrel sampels testing. Thank you!
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
🤖 I have created a release \*beep\* \*boop\* --- ### [1.123.1](https://www.github.com/googleapis/java-bigquery/compare/v1.123.0...v1.123.1) (2020-10-23) ### Dependencies * update dependency com.google.apis:google-api-services-bigquery to v2-rev20201015-1.30.10 ([#851](https://www.github.com/googleapis/java-bigquery/issues/851)) ([439eea9](https://www.github.com/googleapis/java-bigquery/commit/439eea95390b72e5aa84ddd9c208475074cf821c)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.13.0 ([#834](https://www.github.com/googleapis/java-bigquery/issues/834)) ([16a105b](https://www.github.com/googleapis/java-bigquery/commit/16a105bdcfbe61e78d79743aa216f281cf57040a)) ### Documentation * **samples:** add export query results to Amazon S3 sample and IT ([#853](https://www.github.com/googleapis/java-bigquery/issues/853)) ([5358620](https://www.github.com/googleapis/java-bigquery/commit/53586207c300002f6bbad3d67f4441729b109f8a)) * **samples:** create and query Amazon s3 data using external table ([#835](https://www.github.com/googleapis/java-bigquery/issues/835)) ([53a56be](https://www.github.com/googleapis/java-bigquery/commit/53a56be8b0878edbc4bc5dd67ed63b48c96d3899)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
No description provided.