feat: add support for Hive partitioning options when creating external tables by ekanth · Pull Request #236 · googleapis/java-bigquery

ekanth · 2020-03-20T07:19:41Z

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Fixes #235 ☕️

googlebot · 2020-03-20T07:19:45Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

ekanth · 2020-03-20T07:21:09Z

@googlebot I signed it!

googlebot · 2020-03-20T07:21:12Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

codecov · 2020-03-20T10:49:37Z

Codecov Report

❗ No coverage uploaded for pull request base (master@6213ea9). Click here to learn what that means.
The diff coverage is 53.33%.

@@            Coverage Diff            @@
##             master     #236   +/-   ##
=========================================
  Coverage          ?   77.53%           
  Complexity        ?     1151           
=========================================
  Files             ?       75           
  Lines             ?     6089           
  Branches          ?      654           
=========================================
  Hits              ?     4721           
  Misses            ?     1019           
  Partials          ?      349

Impacted Files	Coverage Δ	Complexity Δ
...google/cloud/bigquery/HivePartitioningOptions.java	`83.78% <20%> (ø)`	`11 <2> (?)`
...google/cloud/bigquery/ExternalTableDefinition.java	`57.69% <70%> (ø)`	`19 <1> (?)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6213ea9...5d017bd. Read the comment docs.

stephaniewang526 · 2020-03-20T14:33:42Z

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/ExternalTableDefinition.java

+   */
+  @SuppressWarnings("unchecked")
+  @Nullable
+  public abstract HivePartitioningOptions getHivePartitioningOptions();


this breaks binary compatibility

Thanks @stephaniewang526 for the review. I will update the patch and send again.

@stephaniewang526, @pmakani I updated the patch and I wonder if the tests would automatically run?

@stephaniewang526, thanks for triggering the tests. It was my bad with the previous patch - I missed a line that I fixed locally related to the test failures. Could you please trigger the tests again?

Thanks @stephaniewang526. All tests passed now.

stephaniewang526 · 2020-03-20T14:45:01Z

In general, when you make a commit please be sure to:

make initial commit message in the format - "feat: blah blah..." (note that "blah" has a space in front of the colon and is in lowercase)
run maven coveo code formatter so that code format is correct: mvn com.coveo:fmt-maven-plugin:format
check and make sure all builds succeed and correct any build failures. In this case, abstract classes were added which break binary compatibility --

[ERROR] 7013: com.google.cloud.bigquery.ExternalTableDefinition: Abstract method 'public com.google.cloud.bigquery.HivePartitioningOptions getHivePartitioningOptions()' has been added
[ERROR] 7013: com.google.cloud.bigquery.ExternalTableDefinition$Builder: Abstract method 'public com.google.cloud.bigquery.ExternalTableDefinition$Builder setHivePartitioningOptions(com.google.cloud.bigquery.HivePartitioningOptions)' has been added

we don't want to do this because this renders our client unstable and would break customer's existing implementation. I suggest to try either implement without abstract and add default implementation or encapsulate with an inner method.

…l tables (googleapis#235)

stephaniewang526 · 2020-03-20T14:45:51Z

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/ExternalTableDefinition.java

    public abstract Builder setSchema(Schema schema);

+    /** Sets the table Hive partitioning options. */
+    public abstract Builder setHivePartitioningOptions(HivePartitioningOptions hivePartitioningOptions);


this breaks binary compatibility

🤖 I have created a release \*beep\* \*boop\* --- ## [1.110.0](https://www.github.com/googleapis/java-bigquery/compare/v1.109.0...v1.110.0) (2020-03-20) ### Features * add support for Hive partitioning options when creating external tables ([#235](https://www.github.com/googleapis/java-bigquery/issues/235)) ([#236](https://www.github.com/googleapis/java-bigquery/issues/236)) ([ccc2bb3](https://www.github.com/googleapis/java-bigquery/commit/ccc2bb3de28a36e3791d5441c8bdea2333877ee8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Mar 20, 2020

googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Mar 20, 2020

ekanth force-pushed the master branch from d1ee6c0 to b5431b0 Compare March 20, 2020 07:26

pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 20, 2020

pmakani requested a review from stephaniewang526 March 20, 2020 10:44

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 20, 2020

stephaniewang526 reviewed Mar 20, 2020

View reviewed changes

ekanth force-pushed the master branch from b5431b0 to 618ce09 Compare March 20, 2020 17:14

stephaniewang526 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 20, 2020

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 20, 2020

feat: add support for Hive partitioning options when creating externa…

5d017bd

…l tables (googleapis#235)

ekanth force-pushed the master branch from 618ce09 to 5d017bd Compare March 20, 2020 20:02

stephaniewang526 changed the title ~~Add support for Hive partitioning options when creating external tables~~ feat: add support for Hive partitioning options when creating external tables Mar 20, 2020

stephaniewang526 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 20, 2020

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 20, 2020

stephaniewang526 approved these changes Mar 20, 2020

View reviewed changes

stephaniewang526 merged commit ccc2bb3 into googleapis:master Mar 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add support for Hive partitioning options when creating external tables#236

feat: add support for Hive partitioning options when creating external tables#236
stephaniewang526 merged 1 commit intogoogleapis:masterfrom
ekanth:master

ekanth commented Mar 20, 2020

Uh oh!

googlebot commented Mar 20, 2020

Uh oh!

ekanth commented Mar 20, 2020

Uh oh!

googlebot commented Mar 20, 2020

Uh oh!

codecov bot commented Mar 20, 2020 •

edited

Loading

Uh oh!

stephaniewang526 Mar 20, 2020

Uh oh!

ekanth Mar 20, 2020

Uh oh!

ekanth Mar 20, 2020

Uh oh!

ekanth Mar 20, 2020

Uh oh!

ekanth Mar 20, 2020

Uh oh!

stephaniewang526 commented Mar 20, 2020

Uh oh!

stephaniewang526 Mar 20, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

ekanth commented Mar 20, 2020

Uh oh!

googlebot commented Mar 20, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

ekanth commented Mar 20, 2020

Uh oh!

googlebot commented Mar 20, 2020

Uh oh!

codecov bot commented Mar 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

stephaniewang526 Mar 20, 2020

Choose a reason for hiding this comment

Uh oh!

ekanth Mar 20, 2020

Choose a reason for hiding this comment

Uh oh!

ekanth Mar 20, 2020

Choose a reason for hiding this comment

Uh oh!

ekanth Mar 20, 2020

Choose a reason for hiding this comment

Uh oh!

ekanth Mar 20, 2020

Choose a reason for hiding this comment

Uh oh!

stephaniewang526 commented Mar 20, 2020

Uh oh!

stephaniewang526 Mar 20, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Mar 20, 2020 •

edited

Loading