fix: add fetch_id_token_credentials #866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
busunkim96
reviewed
Sep 14, 2021
Contributor
busunkim96
left a comment
There was a problem hiding this comment.
LGTM. Could a test be added for the new function?
|
+1 for test |
Contributor
|
googleapis/google-cloud-python#15222 is it related? |
mik-laj
reviewed
Sep 14, 2021
mik-laj
reviewed
Sep 14, 2021
mik-laj
reviewed
Sep 14, 2021
6f0e1d8 to
cebcc6c
Compare
Contributor
Author
It resolves 590 partially (it doesn't support user credential) |
cebcc6c to
3e05f72
Compare
3e05f72 to
6395621
Compare
busunkim96
approved these changes
Oct 29, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Nov 1, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [2.3.3](https://www.github.com/googleapis/google-auth-library-python/compare/v2.3.2...v2.3.3) (2021-11-01) ### Bug Fixes * add fetch_id_token_credentials ([#866](https://www.github.com/googleapis/google-auth-library-python/issues/866)) ([8f1e9cf](https://www.github.com/googleapis/google-auth-library-python/commit/8f1e9cfd56dbaae0dff64499e1d0cf55abc5b97e)) * fix error in sign_bytes ([#905](https://www.github.com/googleapis/google-auth-library-python/issues/905)) ([ef31284](https://www.github.com/googleapis/google-auth-library-python/commit/ef3128474431b07d1d519209ea61622bc245ce91)) * use 'int.to_bytes' and 'int.from_bytes' for py3 ([#904](https://www.github.com/googleapis/google-auth-library-python/issues/904)) ([bd0ccc5](https://www.github.com/googleapis/google-auth-library-python/commit/bd0ccc5fe77d55f7a19f5278d6b60587c393ee3c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #865
fetch_id_tokencreates a credentials, refresh it, then return the token. In this PR, we refactor the credentials creation part infetch_id_tokenmethod to a newfetch_id_token_credentialsmethod.Note that we only support service account credentials and compute engine credentials, not user credentials.
The usage is: