johnrom

Hi Alex,

It was not a public plugin. I don’t think plugins should be switching out custom versions of WordPress-provided jQuery plugins, so I personally wouldn’t worry about this issue.

If you really think it is necessary to fix, you can test the functionality by adding an action to wp_enqueue_scripts where you enqueue a custom version of jquery-serialize-object. Something like this should work:

function algol_custom_assets() {
    
    wp_enqueue_script( 
        'custom-serialize-object', 
        'https://cdnjs.cloudflare.com/ajax/libs/jquery-serialize-object/2.4.5/jquery.serialize-object.min.js', 
        array('jquery'), 
        '2.4.5', 
        true 
    );
}
add_action('wp_enqueue_scripts', 'algol_custom_assets') );

Then you should test if $_POST['json'] starts with ", and if so, run the commands I wrote in my previous comment.

$json_string = trim( $_POST['json'], '"');
$json_string = wp_unslash( $json_string );

$json = json_decode( $json_string, true );

John

P.S., if they override jquery-serialize-object, Woo product variations no longer work either so exporting could be the least of the user’s problems.

• This reply was modified 8 years, 1 month ago by johnrom.
• This reply was modified 8 years, 1 month ago by johnrom.

Hi Alex,

In my opinion, having the $_POST overridden in the first place is making the debug process a headache (how were we ever to know $_POST should have been overridden without reading the entire plugin?). However, the issue here appears to be that the JSON is wrapped in an extra set of quotes.

The form data being sent by JavaScript looks like this:

json="{"settings":""}" which results in json_decode() returning a string that looks like {"settings":""}

Additionally, stripslashes_deep doesn’t do exactly what is needed to parse this string, as there is an issue parsing "\"" from the slashes. It should use wp_unslash instead.

The following is the code that allows me to properly save settings — though I still recommend not overriding $_POST!

$_POST = array_map('stripslashes_deep', $_POST);

// parse json to arrays?
if ( ! empty( $_POST['json'] ) ) {
	$json_string = trim( $_POST['json'], '"');
	$json_string = wp_unslash( $json_string );

	$json = json_decode( $json_string, true );

	if(is_array($json)) {
		$_POST = $_POST + $json;
		unset( $_POST['json'] );
	}
}

• This reply was modified 8 years, 1 month ago by johnrom.
• This reply was modified 8 years, 1 month ago by johnrom.
• This reply was modified 8 years, 1 month ago by johnrom.

Hi Bozz,

All instances of ‘WebPres_Woo_Product_Importer’ passed to call_user_func_array have to be replaced by an instantiated object. In this case, it would be &$this since it is within a class constructor.

If you run a find/replace of ‘WebPres_Woo_Product_Importer’ with &$this, the error will go away and everything should go back to normal.

Here is my version of woo_product_importer.php

John