• Hi,
    nice useful plugin!
    Found some red code elements in the table code in rendered html page source – implied by a few little typing errors in the php code:
    line 2009 would better be:
    $htmlid_set = ‘id=”‘ . $html_id . ‘” ‘;
    and line 2097:
    $html .= ‘</tr>’;
    and line 2107:
    $html .= ‘</tbody></table>’;
    Regards,
    Stefan.

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Author wibergsweb

    (@wibergsweb)

    Hi Stefan!

    Thanks for your input! I’ve updated this in version 1.1.42 🙂

    If you want to share were you’re using it (link) – please tell!

    Thread Starter Stefan Sebechlebsky

    (@ssebech)

    Hi,
    you still forgot the unappropriate </body> at line 1049 (formerly 2097).
    Perhaps, you could also add:
    width=”100%”
    at the end of the <table> statement on line 1022 to keep responsiveness compatibility.
    So far I have your plugin just on a testing site. I am using it in conjunction with
    https://wordpress.org/plugins/wp-datatable/
    for provisioning of DataTables script and css style (http://datatables.net/) to format and control how the table is displayed. The two plugins complement each other very well 🙂

    Plugin Author wibergsweb

    (@wibergsweb)

    you still forgot the unappropriate </body> at line 1049 (formerly 2097).

    I really don’t know which code you are looking at(?), because I have not removed that many rows. I just thought you typed incorrectly first time, because the line numbers didn’t match with my plugins row number. And

    </body>?

    You mean

    </tbody>

    ?

    Perhaps, you could also add: width=”100%”
    at the end of the <table> statement on line 1022 to keep responsiveness compatibility.

    This is not a good idea because you should do all styling through css and not set attributes for styling in elements this way. If you want to set 100% width on the table, just put in this in css:

    table {width:100%;}

    Good to know that it works perfectly with other plugins. Thank you for letting me know!

    • This reply was modified 7 years, 2 months ago by wibergsweb.
    • This reply was modified 7 years, 2 months ago by wibergsweb.
    Thread Starter Stefan Sebechlebsky

    (@ssebech)

    </body>?
    You mean
    </tbody>
    No, there is </body> at line 1049 and this tag should just be removed. Search for the string if you don’t see it at that line number.
    Previously I saw double the number of lines because there was an extra empty line inserted after each original one, somewhere in the process of my downloading the file from Linux to Windows and opening in editor on Windows.

    Plugin Author wibergsweb

    (@wibergsweb)

    ahaaaaa

    Sorry. Now I’ve got it. Plugin’s updated again to 1.1.43! (now the line 1049 maked sense and I removed </body> Thanks a lot!!! :-))

    Thanks for your patience!

    • This reply was modified 7 years, 2 months ago by wibergsweb.
Viewing 5 replies - 1 through 5 (of 5 total)

The topic ‘Some typing errors in the code’ is closed to new replies.