Problem with: onclick=”javascript:window.open

  • Resolved Nadav Levi

    (@123nadav)


    5 months ago

    Hello guys, how are you? I have a very strange issue on my website.

    I actually have three identical websites in terms of design and code.

    However, one of them is causing me problems for no reason, and I can’t solve it.

    I set up an exclusion list for several social media external links:
    https://ibb.co/0pPj6f0H

    The problem is the Facebook icon (link), The Facebook icon is an actual external link to my Facebook page.

    For some reason, it doesn’t work properly with:

    onclick="javascript:window.open"

    If I’m not in incognito mode, the page opens in the same tab instead of a new window. when i click F12 and inspect the Facebook icon its not shows me the: onclick="javascript:window.open" for facebook. (for all the other social media its shows)

    I set up my other websites the same way, and it works fine, for example:

    The problem is specific to this website:

    It’s important to note that the other social media icons work perfectly fine.

    All three websites have the same plugin settings and the same code (you can check it using the developer tools, F12).

    Any suggestions?

    The page I need help with: [log in to see the link]

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author Alexandru Tapuleasa

    (@talextech)

    4 months, 4 weeks ago

    I have checked and for me all the links open in a new tab, including Facebook. But Facebook link is missing the javascript, that’s true. But normally just the links having target=”_blank” should be enough for them to open in a new tab. Not sure why you need the JS code on top of that.

    Either way you will need to check whatever is adding that Javascript code as it’s not added by WP External Links so I don’t know what to tell you 🙁

    Thread Starter Nadav Levi

    (@123nadav)

    4 months, 4 weeks ago

    Hi,

    It seems the issue comes from an add-on of your plugin:
    https://wordpress.org/support/plugin/open-external-links-in-a-new-window/

    After checking your settings page, I noticed it clearly says that the add-on uses JavaScript to open new windows.

    I am a bit concerned because when you checked my website earlier, it appears that this add-on injects JavaScript, but it may not have been recognized. I also discovered why the script is not added to my Facebook link.

    My website URL is https://locksmithunit.es

    and my Facebook page is https://www.facebook.com/locksmithunit.es/

    It seems the add-on automatically excludes links that contain my domain name, even when it is only part of the Facebook username.

    I am not sure if there is a solution for this, but based on your response, I would like to know if this add-on is necessary, or if it would be better to simply delete it.

    Thank you in advance for your clarification.

    Plugin Author Alexandru Tapuleasa

    (@talextech)

    4 months, 4 weeks ago

    Hi,

    Well, it’s not an add-on actually, just a different plugin of ours. But if you just want the links to open in a new tab you don’t need it. As those links already have targe=”_blank”.

    Thread Starter Nadav Levi

    (@123nadav)

    4 months, 4 weeks ago

    @talextech in the past when you was install the External Links – nofollow, noopener & new window plugin.

    it was force you to install the open-external-links-in-a-new-window plugin.

    Anyway, i delete this plugin. i am not understand what special about him, xHTML is old, today WordPress read and support html5 so is useless… i delete the plugin.

    Thank you,

    Regards,

    Levi

Viewing 4 replies - 1 through 4 (of 4 total)

You must be logged in to reply to this topic.