PHP Warnings on cache cleanup
-
Hi, I have noticed that when multiple visitors trigger a cache cleanup there are lots of PHP warnings complaining about “No such file or directory” when trying to do unlink.
Since I am very allergic to PHP warnings you should modify /wp-content/plugins/wp-optimize/cache/file-based-page-cache-functions.php on line 1072 to first check if the file exists before trying to remove it.
Something like:
if (file_exists($src . ‘/’ . $file) && !unlink($src . ‘/’ . $file)) {
$success = false;
}
-
In the same way the cache_path function in the WP_Optimize_Minify_Cache_Functions class has a similar reverse race condition where you first check if the directory exists then try to create it, and if someone else beats you to it it will trigger an error.
if (!is_dir($target) && !wp_mkdir_p($target)) {
error_log(‘WP_Optimize_Minify_Cache_Functions::cache_path(): The folder “‘.$target.'” could not be created.’);
}Could perhaps be:
if (!is_dir($target) && !wp_mkdir_p($target)) {
if(!is_dir($target))
error_log(‘WP_Optimize_Minify_Cache_Functions::cache_path(): The folder “‘.$target.'” could not be created.’);
}
The topic ‘PHP Warnings on cache cleanup’ is closed to new replies.
