Good work.

  • bat6oko

    (@bat6oko)


    10 years, 2 months ago

    Keep that way. Need few more things but very good indeed.
    I’ve noticed lack of db cleaning for unsubscribed ones. Master clean button will be good to be added. Custom push messages different from post notifications will be good option too. Detailed logs can be divided by browser. Combined notifications for new post and post update for the same post may make this perfect ad-don for any wordpress owner in future.
    I will send yo pot file in my native language(Bulgarian) in contribution.

Viewing 1 replies (of 1 total)
  • Plugin Author Marco Castelluccio

    (@marco-c-1)

    10 years, 2 months ago

    Thank you for your review!

    The cleanup should happen automatically, the expired subscriptions will be removed once your next notification is sent (basically, the plugin tries to send a notification and it removes the subscription if it fails).
    So, it won’t happen as soon as a user unsubscribes, but will happen eventually.

    I’m thinking about adding custom push notifications (https://github.com/mozilla/wp-web-push/issues/195). Your input on how you would like to see the statistics for this kind of notification would be useful (a single notification clicked/notification opened number for all custom notifications or multiple numbers, one for each custom notification).

    What do you mean by “combined notifications for new post and post update”?

    The plugin is on GitHub, you can file issues there: https://github.com/mozilla/wp-web-push/issues.

Viewing 1 replies (of 1 total)

The topic ‘Good work.’ is closed to new replies.