Editor console warning

  • Resolved Code Amp

    (@codeamp)


    3 years, 7 months ago

    Hi just thought I’d let you know that I noticed an warning in the Javascript console when in the block editor:

    react-dom.js?ver=17.0.1:61 Warning: Invalid DOM property 'fill-rule'. Did you mean 'fillRule'?
    at path
    at svg
    at span
    at div
    at s (http://localhost:8500/wp-content/themes/blocksy/static/bundle/32.6b6e363eda9a039182ed.js:1:219)

    Thanks

    • This topic was modified 3 years, 7 months ago by Code Amp.
Viewing 7 replies - 1 through 7 (of 7 total)
  • Eduard

    (@cteduard)

    3 years, 7 months ago

    Hi @codeamp

    Could you please get back to us with a little bit more detail on this one? How did you replicate the issue? I have checked the editor thoroughly and couldn’t replicate it.

    Waiting on your reply 🙂

    Thanks!

    Thread Starter Code Amp

    (@codeamp)

    3 years, 7 months ago

    Hey @cteduard

    This is just on my dev environment. I double checked with the following setup:

    – Latest WP
    – No plugins enabled
    – Blocksy theme
    – Sample content generated from FakerPress plugin (and disabled)

    Here is a video:
    https://drive.google.com/file/d/1R61Nugd4npS9GBK7D9QvkXRSKKsZD9Ue/view?usp=drivesdk

    Thanks

    Eduard

    (@cteduard)

    3 years, 7 months ago

    Hi @codeamp

    Ok, so I just verified this with our developers and on a clean install with faker press we cannot replicate this issue at all. Check this short video out — https://streamable.com/saaa8j.

    I’m thinking there might be some kind of caching issue or something with the localhost setup? Have you tried reinstalling the theme from scratch? Just delete the folder and reinstall it from the wp store.

    Thanks!

    Eduard

    (@cteduard)

    3 years, 7 months ago

    Hi @codeamp

    Just a kind reminder about this thread. Have you been able to verify the issue? 🙂

    Thanks!

    Thread Starter Code Amp

    (@codeamp)

    3 years, 7 months ago

    Hey @cteduard

    So I tested it on a clean install, and didn’t see the issue immediately upon going to the editor.

    I did delete blocksy and re-install on my dev (pretty clean) install and the issue came back.

    Switching to another theme made the issue go away.

    I’m not 100% sure what’s causing this, this install doesn’t have any plugins enabled or custom code running.. And it is only a warning, not an error.

    But still I’m curious… Looking at the bundled JS file: themes/blocksy/static/bundle/32.6b6e363eda9a039182ed.js

    I can see "fill-rule": "evenodd", and if that is being used in a React component as a prop (it looks like it is) then the warning imo is valid, a React component should have the propfillRule instead (on the SVG I’m guessing).

    Anyway, I’m not sure the conditions to replicate the warning, but my guess is based on looking at the code, the warning is valid…

    Not sure that helps a lot!

    FYI, I am just testing Blocksy (amongst other themes) for compatibility with a plugin I’m building.

    Thanks

    • This reply was modified 3 years, 7 months ago by Code Amp.
    Theme Author Creative Themes

    (@creativethemeshq)

    3 years, 7 months ago

    @codeamp Thanks a lot for your input.

    The fill-rule prop in that file is only in one place — in the notification that Blocksy theme displays about the missing Companion plugin: https://share.cleanshot.com/ckOfmh
    This particular one will be fixed.

    But, this doesn’t explain why you get this error in the block editor. This notification is not rendered at all on that screen.

    Anyways, if you manually edit fill-rule to fillRule in themes/blocksy/static/bundle/32.6b6e363eda9a039182ed.js, does the error go away in the block editor?
    If it does, next update of the theme will have that fixed completely.

    Thanks again for your help.

    Thread Starter Code Amp

    (@codeamp)

    3 years, 7 months ago

    Strange, without explanation, the error has dissapeared…

    I dismissed the notice, then deleted the option (for the dismissed notice) from the options table, and now I can’t reproduce.

    My best guess as to why maybe this notice was triggering was I was creating posts using a plugin that generated them for the classic editor.

    Anyway, I’ve see you’ve closed this, and I can no longer reproduce, so probably best to leave it that way!

    Cheers

    • This reply was modified 3 years, 7 months ago by Code Amp.
Viewing 7 replies - 1 through 7 (of 7 total)

The topic ‘Editor console warning’ is closed to new replies.

Tags