CSS Variables some wrong

  • Resolved candell

    (@candell)


    8 months, 4 weeks ago

    Hi

    Firstly, thank you for an amazing slider plugin. I only found you today so came in at V2 which is super simple to use with great customisation.

    I think I found a little niggle, the css variables don’t all work (thanks for making this customisation so simple BTW, saves hunting around for classes etc). For example,

    –wp–custom–carousel-block–pagination-bullet-horizontal-gap

    is actually referenced in the css as

    –swiper-pagination-bullet-horizontal-gap

    Thanks again

Viewing 2 replies - 1 through 2 (of 2 total)
  • miller2287

    (@miller2287)

    8 months, 3 weeks ago

    I noticed that --wp--custom--carousel-block--navigation-fullwidth-color is actually --wp--custom--carousel-block--navigation-alignfull-color . Can this be corrected in the documentation?

    Plugin Author Virgildia

    (@virgildia)

    7 months, 4 weeks ago

    @candell I’m really glad you’re enjoying the plugin!

    --swiper-pagination-bullet-horizontal-gap is from Swiper’s default CSS variables which are definitely usable if you want to style things directly. On top of that the plugin also provides custom --wp--custom--carousel-block--... CSS variables intended for use in theme.json or custom styles. I recommend using these where possible for cleaner integration with WordPress theming.

    As for the specific variable --wp--custom--carousel-block--pagination-bullet-horizontal-gap, it wasn’t actually included in the CSS. I’ve just added it so it should now work as expected.

    @miller2287 thanks you for reporting that! I corrected the docs.

Viewing 2 replies - 1 through 2 (of 2 total)

The topic ‘CSS Variables some wrong’ is closed to new replies.