CSS Validation Errors on Inline CSS

  • Resolved Michael Dinerstein (Mission Mike)

    (@missionmike)


    5 years, 7 months ago

    First off: Thank you for your work on this awesome plugin!

    The following inline styles contain invalid CSS. Line #s correspond to the validation errors in this screenshot: https://imgur.com/a/cSN5LCb

    Line 89: .pum-theme-94244 .pum-container, .pum-theme-default-theme .pum-container { padding: 18px; border-radius: px; border: 1px none #000000; box-shadow: 1px 1px 3px px rgba( 2, 2, 2, 0.23 ); background-color: rgba( 249, 249, 249, 1.00 ) }

    Line 90: .pum-theme-94244 .pum-title, .pum-theme-default-theme .pum-title { color: #000000; text-align: left; text-shadow: px px px rgba( 2, 2, 2, 0.23 ); font-family: inherit; font-weight: 400; font-size: 32px; font-style: normal; line-height: 36px }

    Line 92: .pum-theme-94244 .pum-content + .pum-close, .pum-theme-default-theme .pum-content + .pum-close { position: absolute; height: auto; width: auto; left: auto; right: px; bottom: auto; top: px; padding: 8px; color: #ffffff; font-family: inherit; font-weight: 400; font-size: 12px; font-style: inherit; line-height: 36px; border: 1px none #ffffff; border-radius: px; box-shadow: 1px 1px 3px px rgba( 2, 2, 2, 0.23 ); text-shadow: px px px rgba( 0, 0, 0, 0.23 ); background-color: rgba( 0, 183, 205, 1.00 ) }

    I have this temporarily patched on my staging site by adding these (hacky) lines on 70-72 in includes/functions/themes/template.php :

    $value = $value === ‘px’ ? ‘0px’ : $value; // If no value is included with ‘px’, default to zero
    $value = substr($value, 0, 2) === ‘px’ ? ‘0’ . $value : $value; // If the first two charactesr of the value are ‘px’, prefix a zero on value
    $value = str_replace( ‘ px’, ‘ 0px’, $value ); // Replace any stray ‘px’ values with ‘0px’

    I’m unable to deactivate the Inline CSS feature (even though “Don’t load popup theme styles to the head.”) –setting appears to save, but has no effect. Inline CSS remains in HTML output.

    No PHP errors or warnings are getting logged; running WordPress 5.5 on PHP 7.4 and MariaDB 10.3. No caching plugin enabled.

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author Daniel Iser

    (@danieliser)

    5 years, 6 months ago

    @missionmike – Sorry for the confusion and delayed response. You need to make sure that Asset Caching in your Popup Maker settings is not disabled first off.

    That would prevent inline styles and save them to a static file.

    That said, this issue has nothing to do with invalid CSS though your hack might prevent such an issue. The real issue is why those theme values are missing in the first place.

    I’d edit your popup themes (Popup Maker -> Themes) and reset the values for each of those options to a valid integer, save and see if that resolves it for you. But this is the first I’ve seen it in 5+ years so my gut says we don’t need to make changes as much as determine how your data got corrupted in the first place.

    Hope that helps. If your issue is resolved please take a moment to rate and review the plugin or support.

    If you still need help please message us directly at https://wppopupmaker.com/support/.

    Thread Starter Michael Dinerstein (Mission Mike)

    (@missionmike)

    5 years, 6 months ago

    @danieliser thank you so much for the reply and insight. No problem re: delay, I understand being very busy. You pointed me in the right direction – I simply opened up the “Default Theme” and clicked “Update” to refresh the values in the database, and sure enough the errors are gone.

    I didn’t realize that the default values were pulled from the database. Thanks again for your help!

    Plugin Author Daniel Iser

    (@danieliser)

    5 years, 6 months ago

    @missionmike – Not a problem. This type of data corruption usually comes from partial migrations, example moving data from staging to live, but only wp_options table, negating other changes that could have occurred in the DB.

    Otherwise it might be something like Redis object cache having stored invalid data at some point and not expiring it.

    Glad you got it worked out.

    Please take a moment to rate and review the plugin or support.

Viewing 3 replies - 1 through 3 (of 3 total)

The topic ‘CSS Validation Errors on Inline CSS’ is closed to new replies.