Block checkout payment method change causes error

Chatgpt suggested fix.
In wt-smart-coupon-public.js

Change this:
$(‘.wc-block-components-shipping-rates-control input[type=”radio”]:checked’).each(function(){ let prefix = $(this).attr(‘name’).split(‘-‘).pop(); shipping_method[prefix] = $(this).val(); });

To this:
$(‘.wc-block-components-shipping-rates-control input[type=”radio”]:checked’).each(function(){
const name = $(this).attr(‘name’) || ”;
// Try bracket syntax first: shipping_method[0]
const m = name.match(/[(\d+)]/);
let prefix = m ? m[1] : (name.includes(‘-‘) ? name.split(‘-‘).pop() : ‘0’);

const val = $(this).val();
if (typeof val === ‘string’ && val.length) {
shipping_method[prefix] = val;
}
});

Handles both shipping_method[0] and shipping-method-0.

Never calls .split() on undefined.

Falls back to package index '0' if neither pattern is present.

Skips empty/undefined values safely.

@webtoffeesupport Thank you for the quick reply.

I would also like to raise another issue.

Smart coupons reserves space for coupons by creating a wrapper div above the checkout form.
The wrapper classes: wbte_sc_block_coupon_wrapper_div and wt_coupon_wrapper.
I don’t use the feature to display coupons in the checkout but Smart Coupons reserves the space anyway and creates an unneccesary dom element and whitespace in the checkout.
Can your developers also see about removing the wrapper divs?

See image here: https://pasteboard.co/5L11zjLKhToB.png

I would suggest making the “Display coupon in” setting a global setting.
There would first be a global setting: “Enable coupons to display” and when selected the the option to display the coupon in myaccount/cart/checkout would appear in the indivual coupon settings.
This would also reduce unneccessary database queries.

• This reply was modified 8 months ago by olppa.
• This reply was modified 8 months ago by olppa.