• Resolved larsontw16

    (@larsontw16)


    I wanted to first say thanks for your hard work on this plugin – I’ve been using it for two years now on seemingly countless client sites and it’s incredible.

    Running into an issue when checking the Aggregate inline JS box, for the SmashBalloon Facebook Feed plugin. All works great when that’s unchecked so I’ve at least narrowed it down to that. Client is adamant about using it so I’m looking to exclude the plugin itself from Autoptimize so it can remain. The issue causes the facebook feed from displaying images, shown here and the “load more” button just spins.

    I can’t seem to locate the directory or js files to exclude… I’ve tried:
    – cff-scripts.js
    – modernizr.custom.js
    – wp-contents/plugins/custom-facebook-feed-pro/
    – and countless other failed attempts I’ve since deleted/forgotten after no success

    This is the js error I’m seeing:
    Uncaught ReferenceError: cffmetatrans is not defined
    at cff-scripts.min.js:123
    at cff_init (cff-scripts.min.js:166)
    at cff-scripts.min.js:188

    Not sure if the error even matters at this point, I was hopeful you could help me in identifying what exclusions I need to add to have AO ignore the plugin/feed? Lost far too much sleep on this, thanks in advance mate.

    The page I need help with: [log in to see the link]

Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Author Optimizing Matters

    (@optimizingmatters)

    Try adding cffmetatrans to the exclusion list maybe? or cffajaxurl or cffajaxurl or cfflinkhashtags should also work, they’re all defined in the same block of inline JS 😉

    Thread Starter larsontw16

    (@larsontw16)

    I went ahead and added them all actually as so:
    – cffmetatrans.js, cffajaxurl.js, cffajaxurl.js, cfflinkhashtags.js

    I’m not seeing any difference in the way the plugin displays. I’m not sure if I misunderstood what you meant as adding them but I’m not sure if that’s excluding the plugin.

    Plugin Author Optimizing Matters

    (@optimizingmatters)

    ah, but you should just use cffmetatrans, don’t add .js 🙂

    Thread Starter larsontw16

    (@larsontw16)

    You’re the man! I’ve managed to solve every previous problem reading your responses on this forum but got stumped here. Thank you so much for your assistance today and for remaining so attentive to your community.

    Going to head over and give you all a review if I haven’t already. Cheers Frank!

    Thread Starter larsontw16

    (@larsontw16)

    Hey Frank, I’ve been working on this since last posting and can’t quite get it right. All issues mentioned before were resolved, but it opened an additional problem. The issue now is lazy-loading is causing image distortion with this plugin, now that the images are able to be displayed since we disabled the js mentioned earlier. In the screenshot below, once “Load More” is clicked, future images are not distorted & plugin support mentioned they are aware of lazy-load compatibility with their product, which leads me to believe its lazy loading skewing the images.

    See distortion: https://imgur.com/a/npPkmkn

    I went through manually adding the feed’s image names as exclusions but because it’s social media, the images rendering above the Load More section are bound to change.

    In order of preference, can we do any of the following?

    Exclude the plugin entirely from AO? Are there additional functions I can exclude to hide this from AO?
    Exclude the page from lazy-loading entirely? I saw your filter on Git but unsure how to implement or if this is still a functioning solution.
    – Exclude the entirety of this page from AO? I saw an older thread you made of doing this but we use Divi and can’t revert to the text editor without Divi saying my page will be reverted/erased.

    The plugin provides a field that allows for adding a class to a feed, perhaps we can add that class as an exclusion?Although I fear the class isn’t being attributed to the <img themselves.

    Really any workaround would be an enormous help here aside from turning lazy-loading off site-wide or leaving it as is. Sorry for the length, wanted to give you as much info as I could.

    Tyler

    Plugin Author Optimizing Matters

    (@optimizingmatters)

    Maybe try adding fbcdn.net to the lazyload exclusion list?

    Thread Starter larsontw16

    (@larsontw16)

    Such a simple response, yet one I didn’t try. I was adding the full URL’s to the specific images and didn’t once try the broad domain.

    Thank you so much for the help, I’m going to reach out to their support to notify them of this solution as I see quite a large number of support req’s for them that are left unsolved.

    Thanks again!

    Plugin Author Optimizing Matters

    (@optimizingmatters)

    you’re welcome larsontw16 🙂

Viewing 8 replies - 1 through 8 (of 8 total)

The topic ‘Aggregate Inline JS – Issue Excluding Script’ is closed to new replies.