Skip to content

Document new parenthesized with statements#24281

Merged
pablogsal merged 2 commits intopython:masterfrom
pablogsal:document_new_with
Jan 25, 2021
Merged

Document new parenthesized with statements#24281
pablogsal merged 2 commits intopython:masterfrom
pablogsal:document_new_with

Conversation

@pablogsal
Copy link
Member

No description provided.

@pablogsal pablogsal requested a review from lysnikolaou January 21, 2021 01:34
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels Jan 21, 2021
@pablogsal pablogsal added skip news skip issue and removed awaiting core review docs Documentation in the Doc dir labels Jan 21, 2021
@pablogsal pablogsal force-pushed the document_new_with branch 4 times, most recently from e2b2088 to 208e3d9 Compare January 21, 2021 02:09
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say much about the parser content, but as a normal user, the text feels pretty straightforward :).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be moved down too (right above the PEP 563 section).

Comment on lines +84 to +86
Copy link
Member

@Fidget-Spinner Fidget-Spinner Jan 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first indent to this entire code block should be indented with 3 spaces not 4 (this might result in a visual difference). If I'm mistaken, apologies in advance and please ignore the comment.

Copy link
Member Author

@pablogsal pablogsal Jan 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first indent to this entire code block should be indented with 3 spaces not 4

Hummmm.....why is that? My understanding is that all indents should be the same in code blocks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2021-01-25 23-04-05

It renders ok to me

pablogsal and others added 2 commits January 25, 2021 23:06
Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
@pablogsal pablogsal merged commit 7c8e0b0 into python:master Jan 25, 2021
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@pablogsal pablogsal deleted the document_new_with branch May 19, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments