bpo-43163: Handle unclosed parentheses in codeop#24483
Merged
pablogsal merged 3 commits intopython:masterfrom Feb 9, 2021
Merged
bpo-43163: Handle unclosed parentheses in codeop#24483pablogsal merged 3 commits intopython:masterfrom
pablogsal merged 3 commits intopython:masterfrom
Conversation
Member
Author
|
@terryjreedy please, feel free to suggest any new tests that you think it would be good to cover regarding this issue. |
terryjreedy
requested changes
Feb 9, 2021
Member
terryjreedy
left a comment
There was a problem hiding this comment.
I verified that this works from IDLE. Looks good but I would like the suggested change.
|
When you're done making the requested changes, leave the comment: |
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
pablogsal
commented
Feb 9, 2021
pablogsal
commented
Feb 9, 2021
terryjreedy
approved these changes
Feb 9, 2021
Member
|
I though about additional tests and tried some things, which all passed, but I don't think any of them would be useful additions. For further testing, I might locally install Hypotheses and the associated random code generator and them run compile_command with valid, incomplete (snipped valid multiline code), and maybe invalid samples. |
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue43163