bpo-41744: Package NuGet python.props with correct name to be used #22154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NuGet automatically includes .props file from the build directory in the target using the package, but only if the .props file has the correct name: it must be $(id).props Rename python.props correspondingly in all the nuspec variants. Also keep python.props as it were for backward compatibility.
Member
|
Thanks! Just need a NEWS file (click |
Contributor
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 14, 2020
…ythonGH-22154) NuGet automatically includes .props file from the build directory in the target using the package, but only if the .props file has the correct name: it must be $(id).props Rename python.props correspondingly in all the nuspec variants. Also keep python.props as it were for backward compatibility. (cherry picked from commit 7c11a9a) Co-authored-by: Václav Slavík <vaclav@slavik.io>
|
GH-22245 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 14, 2020
…ythonGH-22154) NuGet automatically includes .props file from the build directory in the target using the package, but only if the .props file has the correct name: it must be $(id).props Rename python.props correspondingly in all the nuspec variants. Also keep python.props as it were for backward compatibility. (cherry picked from commit 7c11a9a) Co-authored-by: Václav Slavík <vaclav@slavik.io>
|
GH-22246 is a backport of this pull request to the 3.8 branch. |
miss-islington
added a commit
that referenced
this pull request
Sep 14, 2020
…H-22154) NuGet automatically includes .props file from the build directory in the target using the package, but only if the .props file has the correct name: it must be $(id).props Rename python.props correspondingly in all the nuspec variants. Also keep python.props as it were for backward compatibility. (cherry picked from commit 7c11a9a) Co-authored-by: Václav Slavík <vaclav@slavik.io>
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
…ythonGH-22154) NuGet automatically includes .props file from the build directory in the target using the package, but only if the .props file has the correct name: it must be $(id).props Rename python.props correspondingly in all the nuspec variants. Also keep python.props as it were for backward compatibility.
methane
pushed a commit
that referenced
this pull request
Oct 21, 2020
…H-22154) NuGet automatically includes .props file from the build directory in the target using the package, but only if the .props file has the correct name: it must be $(id).props Rename python.props correspondingly in all the nuspec variants. Also keep python.props as it were for backward compatibility. (cherry picked from commit 7c11a9a) Co-authored-by: Václav Slavík <vaclav@slavik.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NuGet automatically includes
.propsfile from the build directory in the target using the package, but only if the file has the correct name: it must be$(id).props. This means that Python's support for this only works correctly in thepythonnuget packages, but not inpythonx86and others, because the file is copied as python.props there too.This PR fixes the problem by renaming the props file appropriately.
https://bugs.python.org/issue41744