Skip to content

bpo-44676: Fix reference leaks in union_reduce #27332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2021
Merged

bpo-44676: Fix reference leaks in union_reduce #27332

merged 1 commit into from
Jul 24, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jul 24, 2021 •
edited by miss-islington
Loading

https://bugs.python.org/issue44676

Automerge-Triggered-By: GH:pablogsal

@pablogsal pablogsal mentioned this pull request Jul 24, 2021
Merged
@pablogsal pablogsal requested a review from Fidget-Spinner July 24, 2021 13:26
Fidget-Spinner
Fidget-Spinner approved these changes Jul 24, 2021
View reviewed changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a neat fix :). Didn't know about the N format string.

@Fidget-Spinner Fidget-Spinner added needs backport to 3.10 only security fixes and removed needs backport to 3.10 only security fixes labels Jul 24, 2021
@Fidget-Spinner
Copy link
Member

Woops I just realized we didn't backport GH-27244. So we don't need to backport this. Thanks the quick fix Pablo!

@pablogsal pablogsal mentioned this pull request Jul 24, 2021
Merged
@pablogsal
Copy link
Member Author

I am backporting GH-27244 with this fix in #27333

corona10
corona10 approved these changes Jul 24, 2021
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 


0:00:00 load avg: 3.08 Run tests sequentially
0:00:00 load avg: 3.08 [1/1] test_types
beginning 6 repetitions
123456
......

== Tests result: SUCCESS ==

1 test OK.

Total duration: 1.1 sec
Tests result: SUCCESS

I also checked that this PR fix the leak issue :)

@miss-islington
Copy link
Contributor

@pablogsal: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 8158e05 into python:main Jul 24, 2021
@pablogsal pablogsal deleted the bpo-44676 branch July 24, 2021 15:22
@pablogsal
Copy link
Member Author

Thanks for the review @corona10 and @Fidget-Spinner !

sthagen added a commit to sthagen/python-cpython that referenced this pull request Jul 24, 2021
@sthagen
Merge pull request #563 from python/main
53fd5ab 
bpo-44676: Fix reference leaks in union_reduce (pythonGH-27332)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pablogsal @Fidget-Spinner @miss-islington @corona10 @the-knights-who-say-ni @bedevere-bot