Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parking_lot.c should check for overflow in Windows _PySemaphore_PlatformWait code path #112804

Open
colesbury opened this issue Dec 6, 2023 · 0 comments
Open

parking_lot.c should check for overflow in Windows _PySemaphore_PlatformWait code path #112804

colesbury opened this issue Dec 6, 2023 · 0 comments
Labels
3.13 bugs and security fixes OS-windows topic-free-threading type-bug An unexpected behavior, bug, or error

Comments

@colesbury
Copy link
Contributor

colesbury commented Dec 6, 2023 •
edited by bedevere-app bot
Loading

Bug report

The cast in millis = (DWORD) (timeout / 1000000); may overflow because DWORD is an unsigned 32-bit integer and timeout is a 64-bit integer. We should clamp the result if the cast would overflow.

cpython/Python/parking_lot.c

Lines 93 to 105 in cc7e45c

static int
_PySemaphore_PlatformWait(_PySemaphore *sema, _PyTime_t timeout)
{
int res;
#if defined(MS_WINDOWS)
DWORD wait;
DWORD millis = 0;
if (timeout < 0) {
millis = INFINITE;
}
else {
millis = (DWORD) (timeout / 1000000);
}

Noticed by @vstinner in #112733 (review)

Linked PRs
@colesbury colesbury added type-bug An unexpected behavior, bug, or error 3.13 bugs and security fixes topic-free-threading labels Dec 6, 2023
@colesbury colesbury mentioned this issue Dec 6, 2023
Merged
corona10 added a commit to corona10/cpython that referenced this issue Oct 3, 2024
@corona10
pythongh-112804: Clamping timeout value for _PySemaphore_PlatformWait
6cc71a5
@bedevere-app bedevere-app bot mentioned this issue Oct 3, 2024
Merged
corona10 added a commit that referenced this issue Oct 5, 2024
@corona10
gh-112804: Clamping timeout value for _PySemaphore_PlatformWait (gh-1…
a5fc509 
…24914)

* gh-112804: Clamping timeout value for _PySemaphore_PlatformWait

* Address code review

* nit
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 5, 2024
@corona10 @miss-islington
pythongh-112804: Clamping timeout value for _PySemaphore_PlatformWait (…
8a79c85 
…pythongh-124914)

* pythongh-112804: Clamping timeout value for _PySemaphore_PlatformWait

* Address code review

* nit
(cherry picked from commit a5fc509)

Co-authored-by: Donghee Na <donghee.na@python.org>
@miss-islington miss-islington mentioned this issue Oct 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.13 bugs and security fixes OS-windows topic-free-threading type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@colesbury @Eclips4