New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataFlow: Support stateless isSink in StateConfigSigs
#13851
Open
MathiasVP
wants to merge
5
commits into
github:main
Choose a base branch
from
MathiasVP:sink-without-states
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+117
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a43823c
to
f3e3dac
Compare
aschackmull
reviewed
Jul 31, 2023
aschackmull
reviewed
Jul 31, 2023
aschackmull
reviewed
Jul 31, 2023
aschackmull
reviewed
Jul 31, 2023
aschackmull
reviewed
Jul 31, 2023
aschackmull
requested changes
Jul 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to need some changes.
f3e3dac
to
8399d4f
Compare
8399d4f
to
d755b39
Compare
d755b39
to
3007fda
Compare
|
@aschackmull I've rebased the PR now that #13863 has been merged ( |
|
Hmmm @aschackmull I think adding the additional conjuncts to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it's necessary to have a state-based configuration to define the correct
isBarrier, but if data then does manage to reach a sink, any state should be accepted. Prior to this PR, the only way to prevent a cartesian product would be to do something like:because there was no
isSink/1onStateConfigSig. With this PR we can now do:with no
PruningFlowmess.cc @aschackmull I hope this isn't too controversial?