New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataflow: Move the shared library to a properly shared qlpack. #13863
base: main
Are you sure you want to change the base?
Conversation
6ce4cbf
to
3904be2
Compare
| /** | ||
| * The cost limits for the `AccessPathFront` to `AccessPathApprox` expansion. | ||
| * | ||
| * `apLimit` bounds the acceptable fan-out, and `tupleLimit` bounds the | ||
| * estimated per-`AccessPathFront` tuple cost. Access paths exceeding both of | ||
| * these limits are represented with lower precision during pruning. | ||
| */ |
Check warning
Code scanning / CodeQL
Predicate QLDoc style. Warning
| /** | ||
| * The cost limits for the `AccessPathApprox` to `AccessPath` expansion. | ||
| * | ||
| * `apLimit` bounds the acceptable fan-out, and `tupleLimit` bounds the | ||
| * estimated per-`AccessPathApprox` tuple cost. Access paths exceeding both of | ||
| * these limits are represented with lower precision. | ||
| */ |
Check warning
Code scanning / CodeQL
Predicate QLDoc style. Warning
| * Constructs a global data flow computation. | ||
| */ | ||
| module Global<ConfigSig Config> implements GlobalFlowSig { | ||
| private module C implements FullStateConfigSig { |
Check warning
Code scanning / CodeQL
Data flow configuration module naming Warning
| * Constructs a global data flow computation using flow state. | ||
| */ | ||
| module GlobalWithState<StateConfigSig Config> implements GlobalFlowSig { | ||
| private module C implements FullStateConfigSig { |
Check warning
Code scanning / CodeQL
Data flow configuration module naming Warning
3904be2
to
199d143
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Swift changes LGTM.
I'd like to see DCA runs on this pull request.
I'll start those shortly - I just wanted to clear out the worst compilation errors with some quick CI first. |
Several small tweaks were needed for the individual languages to ensure that the predicate types matched the signature.