Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Windows build of Python does not need incremental linker support for release and PGO builds #92984

Closed
dmachaj opened this issue May 19, 2022 · 0 comments · Fixed by #92985
Closed

The Windows build of Python does not need incremental linker support for release and PGO builds #92984

dmachaj opened this issue May 19, 2022 · 0 comments · Fixed by #92985
Labels
OS-windows type-bug An unexpected behavior, bug, or error

Comments

@dmachaj
Copy link
Contributor

dmachaj commented May 19, 2022

Bug report
By default when the /debug option is specified for link.exe, so that it will produce a .pdb file, it will assume that incremental linking should also be enabled. Incremental linking creates an incompatibility with some binary analysis tools. Those tools, such as SizeBench are useful so I think it makes sense to disable incremental linking so that they can be used.

Your environment
This behavior was verified using a fresh clone of this repo as of yesterday (main branch). I built using the most recent 17.2.0 toolset from Visual Studio 2022. After running pcbuild/build.bat --pgo I was unable to analyze the resulting python312.dll file because of incremental linking.
@dmachaj dmachaj added the type-bug An unexpected behavior, bug, or error label May 19, 2022
@dmachaj dmachaj mentioned this issue May 19, 2022
Merged
zooba pushed a commit that referenced this issue May 19, 2022
@dmachaj
gh-92984: Explicitly disable incremental linking for Windows Release …
38feffa 
…and PGO builds (GH-92985)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 19, 2022
@dmachaj @miss-islington
pythongh-92984: Explicitly disable incremental linking for Windows Re…
8f9fcd2 
…lease and PGO builds (pythonGH-92985)

(cherry picked from commit 38feffa)

Co-authored-by: David Machaj <46852402+dmachaj@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 19, 2022
@dmachaj @miss-islington
pythongh-92984: Explicitly disable incremental linking for Windows Re…
467e14d 
…lease and PGO builds (pythonGH-92985)

(cherry picked from commit 38feffa)

Co-authored-by: David Machaj <46852402+dmachaj@users.noreply.github.com>
miss-islington added a commit that referenced this issue May 19, 2022
@miss-islington @dmachaj
gh-92984: Explicitly disable incremental linking for Windows Release …
4952608 
…and PGO builds (GH-92985)

(cherry picked from commit 38feffa)

Co-authored-by: David Machaj <46852402+dmachaj@users.noreply.github.com>
miss-islington added a commit that referenced this issue May 19, 2022
@miss-islington @dmachaj
gh-92984: Explicitly disable incremental linking for Windows Release …
76fe10a 
…and PGO builds (GH-92985)

(cherry picked from commit 38feffa)

Co-authored-by: David Machaj <46852402+dmachaj@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS-windows type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
2 participants
@zware @dmachaj