Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-102151: Correctly fetch CONFIG_ARGS in Tools/freeze/test/freeze.py #102152

Merged
merged 1 commit into from Feb 23, 2023
Merged

gh-102151: Correctly fetch CONFIG_ARGS in Tools/freeze/test/freeze.py #102152

merged 1 commit into from Feb 23, 2023
+1 −1

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Feb 22, 2023 •
edited by bedevere-bot

@bedevere-bot bedevere-bot mentioned this pull request Feb 22, 2023
Closed
@erlend-aasland erlend-aasland mentioned this pull request Feb 22, 2023
Merged
corona10
corona10 approved these changes Feb 23, 2023
View changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome LGTM!

@erlend-aasland
Copy link
Contributor Author

Thanks for the review, Dong-hee! I'll wait a day or two for one of the freeze experts to chime in, just in case.

@erlend-aasland erlend-aasland merged commit c3a1783 into python:main Feb 23, 2023
15 checks passed
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@erlend-aasland erlend-aasland deleted the fix-test-tools branch February 23, 2023 14:09
@bedevere-bot
Copy link

GH-102176 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 23, 2023
@erlend-aasland @miss-islington
pythongh-102151: Correctly fetch CONFIG_ARGS in Tools/freeze/test/fre…
5f5f1eb 
…eze.py (pythonGH-102152)

(cherry picked from commit c3a1783)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
miss-islington added a commit that referenced this pull request Feb 23, 2023
@miss-islington @erlend-aasland
gh-102151: Correctly fetch CONFIG_ARGS in Tools/freeze/test/freeze.py (…
3cc0012 
…GH-102152)

(cherry picked from commit c3a1783)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@ericsnowcurrently ericsnowcurrently

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@erlend-aasland @miss-islington @bedevere-bot @corona10 @kumaraditya303