Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_freeze_simple_script in test_tools fails to fetch CONFIG_ARGS #102151

Closed
erlend-aasland opened this issue Feb 22, 2023 · 2 comments
Closed

test_freeze_simple_script in test_tools fails to fetch CONFIG_ARGS #102151

erlend-aasland opened this issue Feb 22, 2023 · 2 comments
Labels
OS-mac tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Feb 22, 2023 •
edited by bedevere-bot

Tools/freeze/test/freeze.py fetches CONFIG_ARGS from the [clean] build directory, instead of fetching it from the source directory.

Discovered while working on #102131.

Linked PRs
@erlend-aasland erlend-aasland added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir OS-mac labels Feb 22, 2023
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Feb 22, 2023 •
edited

May Also affect other platforms like *nix, but I've only tested this on macOS.

erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Feb 22, 2023
@erlend-aasland
pythongh-102151: Correctly fetch CONFIG_ARGS in Tools/freeze/test/fre…
d5bd2d1 
…eze.py
@bedevere-bot bedevere-bot mentioned this issue Feb 22, 2023
Merged
@erlend-aasland
Copy link
Contributor Author

See also Ned's comment: #102070 (comment)

@bedevere-bot bedevere-bot mentioned this issue Feb 23, 2023
Merged
erlend-aasland added a commit that referenced this issue Feb 23, 2023
@erlend-aasland
gh-102151: Correctly fetch CONFIG_ARGS in Tools/freeze/test/freeze.py (…
c3a1783 
…#102152)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Feb 23, 2023
@erlend-aasland @miss-islington
pythongh-102151: Correctly fetch CONFIG_ARGS in Tools/freeze/test/fre…
5f5f1eb 
…eze.py (pythonGH-102152)

(cherry picked from commit c3a1783)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
miss-islington added a commit that referenced this issue Feb 23, 2023
@miss-islington @erlend-aasland
gh-102151: Correctly fetch CONFIG_ARGS in Tools/freeze/test/freeze.py (…
3cc0012 
…GH-102152)

(cherry picked from commit c3a1783)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS-mac tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erlend-aasland